From: Patrick McHardy <kaber@trash•net>
To: David Miller <davem@davemloft•net>
Cc: soltys@ziu•info, denys@visp•net.lb, netdev@vger•kernel.org
Subject: Re: [PATCH] net/sched/sch_hfsc.c: initialize parent's cl_cfmin properly in init_vf()
Date: Tue, 21 Sep 2010 17:00:46 +0200 [thread overview]
Message-ID: <4C98C89E.6080103@trash.net> (raw)
In-Reply-To: <20100917.164127.09754402.davem@davemloft.net>
Am 18.09.2010 01:41, schrieb David Miller:
> From: Patrick McHardy <kaber@trash•net>
> Date: Wed, 15 Sep 2010 19:54:49 +0200
>
>> Am 01.09.2010 23:30, schrieb David Miller:
>>> From: Michal Soltys <soltys@ziu•info>
>>> Date: Mon, 30 Aug 2010 23:34:10 +0200
>>>
>>>> This patch fixes init_vf() function, so on each new backlog period parent's
>>>> cl_cfmin is properly updated (including further propgation towards the root),
>>>> even if the activated leaf has no upperlimit curve defined.
>>>>
>>>> Signed-off-by: Michal Soltys <soltys@ziu•info>
>>>
>>> Applied, thanks.
>>
>> For the record, the patch seems fine to me. The root cause seems to be
>> an optimization I introduced (pre-git, even history.git unfortunately)
>> in vttree_get_minvt() that wasn't present in the original version:
>>
>> static struct hfsc_class *
>> vttree_get_minvt(struct hfsc_class *cl, u64 cur_time)
>> {
>> /* if root-class's cfmin is bigger than cur_time nothing to do */
>> if (cl->cl_cfmin > cur_time)
>> return NULL;
>
> Actually, the HFSC scheduler was added with this test present.
> The function had a different name, actlist_get_minvt(), at the
> time. See commit:
>
> commit 6e22ce74ea0666a869ce82f418ce78b5be089fb4
> Author: Patrick McHardy <kaber@trash•net>
> Date: Wed Jan 28 20:15:03 2004 -0800
>
> [NET_SCHED]: Add HFSC packet scheduler.
>
> in the history-2.6 GIT tree.
Indeed, what I meant to say was that I made this optimization
before HFSC was added to BitKeeper, so there's no changelog
present for this particular optimization.
prev parent reply other threads:[~2010-09-21 15:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-30 21:33 [PATCH] HFSC - initialize parent's cl_cfmin properly in init_vf() Michal Soltys
2010-08-30 21:34 ` [PATCH] net/sched/sch_hfsc.c: " Michal Soltys
2010-09-01 21:30 ` David Miller
2010-09-15 17:54 ` Patrick McHardy
2010-09-15 21:42 ` Michal Soltys
2010-09-18 14:08 ` Michal Soltys
2010-09-17 23:41 ` David Miller
2010-09-21 15:00 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C98C89E.6080103@trash.net \
--to=kaber@trash$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=denys@visp$(echo .)net.lb \
--cc=netdev@vger$(echo .)kernel.org \
--cc=soltys@ziu$(echo .)info \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox