Subject: Re: [PATCH] de2104x: fix ethtool

From: Jeff Garzik <[email-masked]>
Date: Mon, 27 Sep 2010 18:05:58 -0400

On 09/27/2010 05:41 PM, Ondrej Zary wrote:
> When the interface is up, using ethtool breaks it because:
> a) link is put down but media_timer interval is not shortened to NO_LINK
> b) rxtx is stopped but not restarted
>
> Also manual 10baseT-HD (and probably FD too - untested) mode does not work -
> the link is forced up, packets are transmitted but nothing is received.
> Changing CSR14 value to match documentation (not disabling link check) fixes this.
>
> Signed-off-by: Ondrej Zary<[email-masked]>

Acked-by: Jeff Garzik <[email-masked]>

Good catch on the missing de_start_rxtx()