From: Michael Tokarev <mjt@tls•msk.ru>
To: Andrey Vagin <avagin@openvz•org>
Cc: stable@kernel•org, netdev@vger•kernel.org,
Krishna Kumar <krkumar2@in•ibm.com>,
"David S. Miller" <davem@davemloft•net>
Subject: Re: [STABLE 2.6.32 PATCH] net: release dst entry while cache-hot for GSO case too
Date: Mon, 11 Oct 2010 19:40:11 +0400 [thread overview]
Message-ID: <4CB32FDB.4090001@msgid.tls.msk.ru> (raw)
In-Reply-To: <1286810413-30238-1-git-send-email-avagin@openvz.org>
Andrey Vagin wrote:
> From: Krishna Kumar <krkumar2@in•ibm.com>
>
> commit 068a2de57ddf4f472e32e7af868613c574ad1d88 upstream.
>
> Non-GSO code drops dst entry for performance reasons, but
> the same is missing for GSO code. Drop dst while cache-hot
> for GSO case too.
>
> Note: Without this patch the kernel may oops if used bridged veth
> devices. A bridge set skb->dst = fake_dst_ops, veth transfers this skb
> to netif_receive_skb...ip_rcv_finish and it calls dst_input(skb), but
> fake_dst_ops->input = NULL -> Oops
Hmm. Isn't this the reason for my mysterious OOPSes (jump to
NULL) which I concluded are due to stack overflow? See f.e.
http://www.spinics.net/lists/netdev/msg142104.html
This started happening when I updated virtio drivers in a windows
virtual machne to the ones which supports GSO, and my config
involves bridging veth devices, and this is where the prob
actually occurs - when doing guest => virtio => tap => bridge => veth
route....
Thanks!
/mjt
next prev parent reply other threads:[~2010-10-11 15:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-11 15:20 [STABLE 2.6.32 PATCH] net: release dst entry while cache-hot for GSO case too Andrey Vagin
2010-10-11 15:40 ` Michael Tokarev [this message]
2010-10-11 15:46 ` Eric Dumazet
2010-10-11 15:59 ` David Miller
2010-10-11 16:19 ` Andrew Vagin
2010-10-11 16:30 ` Eric Dumazet
2010-10-11 16:55 ` Michael Tokarev
2010-10-26 18:54 ` David Miller
2010-12-08 22:47 ` avagin
2010-12-08 23:05 ` Greg KH
2010-12-09 6:43 ` [stable] " avagin
2010-12-09 18:19 ` Greg KH
2010-12-21 0:07 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CB32FDB.4090001@msgid.tls.msk.ru \
--to=mjt@tls$(echo .)msk.ru \
--cc=avagin@openvz$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=krkumar2@in$(echo .)ibm.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stable@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox