From: Daniel Lezcano <daniel.lezcano@free•fr>
To: Hans Schillstrom <hans.schillstrom@ericsson•com>
Cc: lvs-devel@vger•kernel.org, netdev@vger•kernel.org,
netfilter-devel@vger•kernel.org, horms@verge•net.au, ja@ssi•bg,
wensong@linux-vs•org
Subject: Re: [RFC PATCH 1/9] ipvs network name space aware
Date: Mon, 18 Oct 2010 10:59:25 +0200 [thread overview]
Message-ID: <4CBC0C6D.1080303@free.fr> (raw)
In-Reply-To: <201010081316.46690.hans.schillstrom@ericsson.com>
On 10/08/2010 01:16 PM, Hans Schillstrom wrote:
> This part contains the include files
> where include/net/netns/ip_vs.h is new and contains all moved vars.
>
> SUMMARY
>
> include/net/ip_vs.h | 136 ++++---
> include/net/net_namespace.h | 2 +
> include/net/netns/ip_vs.h | 112 +++++
>
> Signed-off-by:Hans Schillstrom<hans.schillstrom@ericsson•com>
> ---
>
>
[ ... ]
> #ifdef CONFIG_IP_VS_IPV6
> diff --git a/include/net/net_namespace.h b/include/net/net_namespace.h
> index bd10a79..b59cdc5 100644
> --- a/include/net/net_namespace.h
> +++ b/include/net/net_namespace.h
> @@ -15,6 +15,7 @@
> #include<net/netns/ipv4.h>
> #include<net/netns/ipv6.h>
> #include<net/netns/dccp.h>
> +#include<net/netns/ip_vs.h>
> #include<net/netns/x_tables.h>
> #if defined(CONFIG_NF_CONNTRACK) || defined(CONFIG_NF_CONNTRACK_MODULE)
> #include<net/netns/conntrack.h>
> @@ -91,6 +92,7 @@ struct net {
> struct sk_buff_head wext_nlevents;
> #endif
> struct net_generic *gen;
> + struct netns_ipvs *ipvs;
> };
>
IMHO, it would be better to use the net_generic infra-structure instead
of adding a new field in the netns structure.
next prev parent reply other threads:[~2010-10-18 8:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-08 11:16 [RFC PATCH 1/9] ipvs network name space aware Hans Schillstrom
2010-10-18 8:59 ` Daniel Lezcano [this message]
2010-10-18 9:54 ` Hans Schillstrom
2010-10-18 11:37 ` Daniel Lezcano
2010-10-18 13:23 ` Hans Schillstrom
2010-10-18 14:26 ` Daniel Lezcano
2010-10-19 18:44 ` Paul E. McKenney
2010-10-20 8:25 ` Hans Schillstrom
2010-10-20 16:02 ` Paul E. McKenney
2010-10-21 7:45 ` Hans Schillstrom
2010-10-21 8:01 ` Eric Dumazet
2010-10-21 15:18 ` Paul E. McKenney
2010-10-21 8:58 ` Eric Dumazet
2010-10-21 15:16 ` Paul E. McKenney
2010-10-21 15:24 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CBC0C6D.1080303@free.fr \
--to=daniel.lezcano@free$(echo .)fr \
--cc=hans.schillstrom@ericsson$(echo .)com \
--cc=horms@verge$(echo .)net.au \
--cc=ja@ssi$(echo .)bg \
--cc=lvs-devel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=netfilter-devel@vger$(echo .)kernel.org \
--cc=wensong@linux-vs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox