From: Daniel Lezcano <daniel.lezcano@free•fr>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: David Miller <davem@davemloft•net>,
ebiederm@xmission•com, netdev@vger•kernel.org
Subject: Re: [PATCH] ipv4: Flush per-ns routing cache more sanely.
Date: Fri, 29 Oct 2010 23:41:40 +0200 [thread overview]
Message-ID: <4CCB3F94.20709@free.fr> (raw)
In-Reply-To: <1288121422.2652.14.camel@edumazet-laptop>
On 10/26/2010 09:30 PM, Eric Dumazet wrote:
> Le mardi 26 octobre 2010 à 12:20 -0700, David Miller a écrit :
>
>> From: ebiederm@xmission•com (Eric W. Biederman)
>> Date: Tue, 26 Oct 2010 12:05:39 -0700
>>
>>
>>>> @@ -999,7 +999,7 @@ static int fib_netdev_event(struct notifier_block *this, unsigned long event, vo
>>>> rt_cache_flush(dev_net(dev), 0);
>>>> break;
>>>> case NETDEV_UNREGISTER_BATCH:
>>>> - rt_cache_flush_batch();
>>>> + rt_cache_flush_batch(dev_net(dev));
>>>>
>>> It still has this incorrect conversion in it.
>>>
>> Sorry I missed that, what's the exact problem with it?
>>
> Because the way _BATCH operation is performed, we call it once...
>
> rollback_registered_many() calls it for the first dev queued in the
> list.
>
> So it should be net independant.
>
Dave,
do you plan to send another version of this patch ? Or can I test it as
it is ?
Without removing a network device, I can check the routine, no ?
Thanks
-- Daniel
next prev parent reply other threads:[~2010-10-29 21:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-26 17:34 [PATCH] ipv4: Flush per-ns routing cache more sanely David Miller
2010-10-26 18:57 ` Eric Dumazet
2010-10-26 18:57 ` Daniel Lezcano
2010-10-26 19:05 ` Eric W. Biederman
2010-10-26 19:20 ` David Miller
2010-10-26 19:30 ` Eric Dumazet
2010-10-29 21:41 ` Daniel Lezcano [this message]
2010-10-29 22:21 ` David Miller
2010-12-20 5:14 ` David Miller
2010-12-20 17:13 ` Eric Dumazet
2010-12-20 18:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CCB3F94.20709@free.fr \
--to=daniel.lezcano@free$(echo .)fr \
--cc=davem@davemloft$(echo .)net \
--cc=ebiederm@xmission$(echo .)com \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox