From: Oliver Hartkopp <socketcan@hartkopp•net>
To: Linus Torvalds <torvalds@linux-foundation•org>
Cc: Dan Rosenberg <drosenberg@vsecurity•com>,
netdev@vger•kernel.org, security@kernel•org
Subject: Re: [Security] [SECURITY] CAN info leak/minor heap overflow
Date: Tue, 02 Nov 2010 21:19:14 +0100 [thread overview]
Message-ID: <4CD07242.8080509@hartkopp.net> (raw)
In-Reply-To: <AANLkTi=EcAQ0u_wYAnVkvV_Ve9in4z2Es5h1pBbyMeXe@mail.gmail.com>
On 02.11.2010 20:57, Linus Torvalds wrote:
> On Tue, Nov 2, 2010 at 3:53 PM, Dan Rosenberg <drosenberg@vsecurity•com> wrote:
>>
>>> Why is this bad? Can the addresses of CAN-BCM sock structs be used for
>>> anything from userspace?
>>>
>>> For me they are just intented to be unique numbers ...
>>>
>>
>> This is a bad idea because it makes exploiting other kernel
>> vulnerabilities easier. Exposing the address of an object in a slab
>> cache, especially an object that unprivileged users have some level of
>> control of, is just an invitation to use that structure when writing
>> exploits, for heap overflows or otherwise.
>
> Indeed. At the very least, hash them and truncate them with some
> secret per-boot value or something. Even better, use something like a
> socket number so that maybe they can be associated with
> /proc/<xyz>/fd/<x> or other system info if somebody were to care.
Good hint!
Will pick this idea.
Thanks,
Oliver
next prev parent reply other threads:[~2010-11-02 20:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-02 18:28 [SECURITY] CAN info leak/minor heap overflow Dan Rosenberg
2010-11-02 19:43 ` Oliver Hartkopp
2010-11-02 19:53 ` Dan Rosenberg
2010-11-02 19:57 ` [Security] " Linus Torvalds
2010-11-02 20:19 ` Oliver Hartkopp [this message]
2010-11-02 20:16 ` Oliver Hartkopp
2010-11-05 18:33 ` [PATCH] Fix " Urs Thuermann
2010-11-09 7:52 ` Oliver Hartkopp
2010-11-09 17:05 ` David Miller
2010-11-10 6:52 ` Oliver Hartkopp
2010-11-10 17:51 ` David Miller
2010-11-10 22:10 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CD07242.8080509@hartkopp.net \
--to=socketcan@hartkopp$(echo .)net \
--cc=drosenberg@vsecurity$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=security@kernel$(echo .)org \
--cc=torvalds@linux-foundation$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox