Subject: Re: [PATCH net-next-2.6 v2] macvlan: lockless tx path

From: Patrick McHardy <[email-masked]>
Date: Fri, 12 Nov 2010 09:20:19 +0100

On 11.11.2010 08:14, Eric Dumazet wrote:
> macvlan is a stacked device, like tunnels. We should use the lockless
> mechanism we are using in tunnels and loopback.
> 
> This patch completely removes locking in TX path.
> 
> tx stat counters are added into existing percpu stat structure, renamed
> from rx_stats to pcpu_stats.
> 
> Note : this reverts commit 2c11455321f37 (macvlan: add multiqueue
> capability)
> 
> Note : rx_errors converted to a 32bit counter, like tx_dropped, since
> they dont need 64bit range.
> 
> Signed-off-by: Eric Dumazet <[email-masked]>
> Cc: Patrick McHardy <[email-masked]>
> Cc: Ben Greear <[email-masked]>
> Cc: Ben Hutchings <[email-masked]>
> ---
> V2: correct kerneldoc
>     u32 for tx_dropped and rx_errors

Looks good to me.

Acked-by: Patrick McHardy <[email-masked]>