From: John Fastabend <john.r.fastabend@intel•com>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: "netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"nhorman@tuxdriver•com" <nhorman@tuxdriver•com>,
"davem@davemloft•net" <davem@davemloft•net>
Subject: Re: [RFC PATCH v1 1/2] net: implement mechanism for HW based QOS
Date: Thu, 18 Nov 2010 10:00:51 -0800 [thread overview]
Message-ID: <4CE569D3.7060504@intel.com> (raw)
In-Reply-To: <1290101963.2781.234.camel@edumazet-laptop>
On 11/18/2010 9:39 AM, Eric Dumazet wrote:
> Le jeudi 18 novembre 2010 à 09:27 -0800, John Fastabend a écrit :
>
>> Thanks for the feedback!
>>
>> num_tx_queues is an unsigned int in net_device and I can't see any
>> place that would limit it to 16bits. So I think we need 32 bits here.
>> Otherwise I will make these changes and fix the fallout. This is much
>> cleaner.
>>
>>
>
> Hmm...
>
> include/linux/skbuff.h
>
> __u16 queue_mapping:16;
>
>
> static inline void skb_record_rx_queue(struct sk_buff *skb, u16 rx_queue)
>
> Anyway, we dont want to have more than 32768 queues, not before year
> 2020 at least
>
> Thanks
>
>
>
Ah a u16 it is then. And more then 32768 queues would be a bit much.
next prev parent reply other threads:[~2010-11-18 18:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 5:15 [RFC PATCH v1 1/2] net: implement mechanism for HW based QOS John Fastabend
2010-11-17 5:15 ` [RFC PATCH v1 2/2] ixgbe: add multiple txqs per tc John Fastabend
2010-11-17 6:56 ` [RFC PATCH v1 1/2] net: implement mechanism for HW based QOS Eric Dumazet
2010-11-18 17:27 ` John Fastabend
2010-11-18 17:39 ` Eric Dumazet
2010-11-18 18:00 ` John Fastabend [this message]
2010-11-17 9:18 ` Thomas Graf
2010-11-18 17:31 ` John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE569D3.7060504@intel.com \
--to=john.r.fastabend@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nhorman@tuxdriver$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox