From: Shan Wei <shanwei@cn•fujitsu.com>
To: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6•org>
Cc: David Miller <davem@davemloft•net>,
Network-Maillist <netdev@vger•kernel.org>,
kuznet@ms2•inr.ac.ru, pekkas@netcore•fi, jmorris@namei•org,
Patrick McHardy <kaber@trash•net>
Subject: Re: [PATCH 1/3] net: kill unused macros in head file
Date: Mon, 29 Nov 2010 16:21:14 +0800 [thread overview]
Message-ID: <4CF3627A.1040401@cn.fujitsu.com> (raw)
In-Reply-To: <1291016563.7802.2.camel@takos>
Hi yoshifuji-san:
YOSHIFUJI Hideaki wrote, at 11/29/2010 03:42 PM:
>>
>> -#define RETRANS_TIMER HZ
>> -
>> #define MAX_RTR_SOLICITATIONS 3
>> #define RTR_SOLICITATION_INTERVAL (4*HZ)
>>
>
> I think we should use it in net/ipv6/addrconf.c,
> instead of magic number.
Do you mean to replace all HZ in net/ipv6/addrconf.c with RETRANS_TIMER?
HZ is also a macro. And I think HZ is more easier to read than RETRANS_TIMER.
--
Best Regards
-----
Shan Wei
next prev parent reply other threads:[~2010-11-29 8:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-29 6:53 [PATCH 1/3] net: kill unused macros in head file Shan Wei
2010-11-29 7:42 ` YOSHIFUJI Hideaki
2010-11-29 8:21 ` Shan Wei [this message]
2010-12-01 20:33 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CF3627A.1040401@cn.fujitsu.com \
--to=shanwei@cn$(echo .)fujitsu.com \
--cc=davem@davemloft$(echo .)net \
--cc=jmorris@namei$(echo .)org \
--cc=kaber@trash$(echo .)net \
--cc=kuznet@ms2$(echo .)inr.ac.ru \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pekkas@netcore$(echo .)fi \
--cc=yoshfuji@linux-ipv6$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox