public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Taku Izumi <izumi.taku@jp•fujitsu.com>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: "netdev@vger•kernel.org" <netdev@vger•kernel.org>,
	Jay Vosburgh <fubar@us•ibm.com>
Subject: Re: [PATCH] bonding: add the sysfs interface to see RLB hash table
Date: Wed, 01 Dec 2010 14:03:35 +0900	[thread overview]
Message-ID: <4CF5D727.3090905@jp.fujitsu.com> (raw)
In-Reply-To: <1291111829.2904.25.camel@edumazet-laptop>


(2010/11/30 19:10), Eric Dumazet wrote:
> Le mardi 30 novembre 2010 à 19:01 +0900, Taku Izumi a écrit :

>> +	hash_index = bond_info->rx_hashtbl_head;
>> +	for (; hash_index != RLB_NULL_INDEX; hash_index = client_info->next) {
>> +		client_info =&(bond_info->rx_hashtbl[hash_index]);
>> +
>> +		count += sprintf(buf + count,
>> +			"%3d.%3d.%3d.%3d %3d.%3d.%3d.%3d "
>> +			"%02x:%02x:%02x:%02x:%02x:%02x %s\n",
> 
> 
> Oh well, I guess you dont read Joe patches on netdev ;)
> 
> Please take a look at %pI4 and %pM
> 
> sprintf(buf + count, "%pI4 %pI4 %pM %s\n", ...)

 Thank you for your advice. I've become a little wiser..

Taku Izumi <izumi.taku@jp•fujitsu.com>


  parent reply	other threads:[~2010-12-01  5:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-30 10:01 [PATCH] bonding: add the sysfs interface to see RLB hash table Taku Izumi
2010-11-30 10:10 ` Eric Dumazet
2010-11-30 18:37   ` Jay Vosburgh
2010-12-01  5:09     ` Taku Izumi
2010-12-01  5:03   ` Taku Izumi [this message]
2010-11-30 22:08 ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CF5D727.3090905@jp.fujitsu.com \
    --to=izumi.taku@jp$(echo .)fujitsu.com \
    --cc=eric.dumazet@gmail$(echo .)com \
    --cc=fubar@us$(echo .)ibm.com \
    --cc=netdev@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox