From: Cong Wang <amwang@redhat•com>
To: Stephen Hemminger <shemminger@vyatta•com>
Cc: linux-kernel@vger•kernel.org, Jiri Pirko <jpirko@redhat•com>,
Neil Horman <nhorman@redhat•com>,
netdev@vger•kernel.org, "David S. Miller" <davem@davemloft•net>,
"Eric W. Biederman" <ebiederm@xmission•com>,
Herbert Xu <herbert@gondor•hengli.com.au>,
bonding-devel@lists•sourceforge.net,
Jay Vosburgh <fubar@us•ibm.com>
Subject: Re: [Patch] bonding: clean up netpoll code
Date: Thu, 02 Dec 2010 11:14:57 +0800 [thread overview]
Message-ID: <4CF70F31.5030204@redhat.com> (raw)
In-Reply-To: <20101201081457.23102445@nehalam>
On 12/02/10 00:14, Stephen Hemminger wrote:
> On Wed, 1 Dec 2010 02:45:45 -0500
> Amerigo Wang<amwang@redhat•com> wrote:
>
>> + if ((slave_dev->npinfo = bond_netpoll_info(bond))) {
>
> Split assignment and conditional into two lines
>
Ok, will change this in the next update.
Thanks!
prev parent reply other threads:[~2010-12-02 3:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-01 7:45 [Patch] bonding: clean up netpoll code Amerigo Wang
2010-12-01 8:03 ` Eric Dumazet
2010-12-01 8:26 ` Cong Wang
2010-12-01 9:06 ` Herbert Xu
2010-12-01 11:15 ` Cong Wang
2010-12-01 16:14 ` Stephen Hemminger
2010-12-02 3:14 ` Cong Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CF70F31.5030204@redhat.com \
--to=amwang@redhat$(echo .)com \
--cc=bonding-devel@lists$(echo .)sourceforge.net \
--cc=davem@davemloft$(echo .)net \
--cc=ebiederm@xmission$(echo .)com \
--cc=fubar@us$(echo .)ibm.com \
--cc=herbert@gondor$(echo .)hengli.com.au \
--cc=jpirko@redhat$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nhorman@redhat$(echo .)com \
--cc=shemminger@vyatta$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox