Subject: Re: [PATCH v2 1/4] net: snmp: fix the wrong ICMP_MIB_MAX value

From: Shan Wei <[email-masked]>
Date: Thu, 02 Dec 2010 18:35:50 +0800

Thomas Graf wrote, at 12/02/2010 05:57 PM:
>>  /* ICMP */
>>  #define ICMP_MIB_DUMMY	__ICMP_MIB_MAX
>> -#define ICMP_MIB_MAX	(__ICMP_MIB_MAX + 1)
>> -
>> +#define ICMP_MIB_MAX	__ICMP_MIB_MAX
> 
> Looks like the +1 is there to account for ICMP_MIB_DUMMY. It is
> unused though but you have to remove it as well if you want to
> kill that extra +1.

I don't know the history about ICMP_MIB_DUMMY before v2.6.12-rc2. 
But after that, it is abandoned.

ICMP_MIB_DUMMY is killed in patch:
［PATCH v2 4/4] net: kill unused macros from head file

-- 
Best Regards
-----
Shan Wei