Subject: Re: [v3 PATCH 1/2] bonding: sync netpoll code with bridge

From: Cong Wang <[email-masked]>
Date: Thu, 09 Dec 2010 15:40:30 +0800

On 12/09/10 15:33, Cong Wang wrote:
>>>
>>>       /* close slave before restoring its mac address */
>>>       dev_close(slave_dev);
>>> @@ -2061,6 +2098,7 @@ static int  bond_release_and_destroy(struct
>>> net_device *bond_dev,
>>>
>>>       ret = bond_release(bond_dev, slave_dev);
>>>       if ((ret == 0)&&  (bond->slave_cnt == 0)) {
>>> +        bond_dev->priv_flags |= IFF_DISABLE_NETPOLL;
>> Why are you setting IFF_DISABLE_NETPOLL here?  That seems unnecessecary
>>
>
> It gets removed in patch 2/2. :)

Oops! I misread IFF_DISABLE_NETPOLL as IFF_IN_NETPOLL...

I think there is a small window between bond_release() and unregister_netdevice(),
setting this could prevent netpoll is setup again on this bond?