Subject: Re: [PATCH 2/9] drivers/net: don't use flush_scheduled_work()

From: Andrew Gallatin <[email-masked]>
Date: Mon, 13 Dec 2010 16:27:45 -0500

On 12/12/10 10:52, Tejun Heo wrote:
> flush_scheduled_work() is on its way out.  This patch contains simple
> conversions to replace flush_scheduled_work() usage with direct
> cancels and flushes.
>
> Directly cancel the used works on driver detach and flush them in
> other cases.
>
> The conversions are mostly straight forward and the only dangers are,
>
> * Forgetting to cancel/flush one or more used works.
>
> * Cancelling when a work should be flushed (ie. the work must be
>    executed once scheduled whether the driver is detaching or not).
>
> I've gone over the changes multiple times but it would be much
> appreciated if you can review with the above points in mind.
>
> Signed-off-by: Tejun Heo<[email-masked]>
> Cc: "David S. Miller"<[email-masked]>
> Cc: Jay Cliburn<[email-masked]>
> Cc: Michael Chan<[email-masked]>
> Cc: Divy Le Ray<[email-masked]>
> Cc: [email-masked]
> Cc: Vasanthy Kolluri<[email-masked]>
> Cc: Samuel Ortiz<[email-masked]>
> Cc: Lennert Buytenhek<[email-masked]>
> Cc: Andrew Gallatin<[email-masked]>
> Cc: Francois Romieu<[email-masked]>
> Cc: Ramkrishna Vepa<[email-masked]>
> Cc: Matt Carlson<[email-masked]>
> Cc: David Brownell<[email-masked]>
> Cc: Shreyas Bhatewara<[email-masked]>
> Cc: [email-masked]
> ---

For the myri10ge part:

Acked-by: Andrew Gallatin <[email-masked]>