From: "Paweł Staszewski" <pstaszewski@itcare•pl>
To: Changli Gao <xiaosuo@gmail•com>
Cc: Eric Dumazet <eric.dumazet@gmail•com>,
Linux Network Development list <netdev@vger•kernel.org>
Subject: Re: Kernel panic eth2 mirred redirect to ifb0
Date: Sun, 19 Dec 2010 21:34:53 +0100 [thread overview]
Message-ID: <4D0E6C6D.10806@itcare.pl> (raw)
In-Reply-To: <AANLkTimMY3D_HssWb=Sw=b3tsxEKACk2QUzFzi-HaC-J@mail.gmail.com>
W dniu 2010-12-19 17:22, Changli Gao pisze:
> 2010/12/20 Paweł Staszewski<pstaszewski@itcare•pl>:
>> W dniu 2010-12-19 16:43, Eric Dumazet pisze:
>>> Unfortunately, we miss the start of panic messages. Could you try to get
>>> them ?
>>>
>> In attached images
>>
> It seems the kernel panic at:
>
> if (skb_shared(skb))
> BUG();
>
> in pskb_expand_head().
>
> It maybe related to my patch:
> http://git.kernel.org/?p=linux/kernel/git/davem/net-next-2.6.git;a=commitdiff;h=210d6de78c5d7c785fc532556cea340e517955e1
>
> You can try to revert it and test again.
>
> However, the bug is a misuse of pskb_expand_head().
>
patching file net/sched/act_mirred.c
Hunk #1 FAILED at 169.
Hunk #2 succeeded at 195 (offset 10 lines).
1 out of 2 hunks FAILED -- saving rejects to file net/sched/act_mirred.c.rej
***************
*** 169,181 ****
goto out;
}
- at = G_TC_AT(skb->tc_verd);
- skb2 = skb_act_clone(skb, GFP_ATOMIC, m->tcf_action);
if (skb2 == NULL)
goto out;
m->tcf_bstats.bytes += qdisc_pkt_len(skb2);
m->tcf_bstats.packets++;
if (!(at & AT_EGRESS)) {
if (m->tcfm_ok_push)
skb_push(skb2, skb2->dev->hard_header_len);
--- 169,181 ----
goto out;
}
+ skb2 = skb_act_clone(skb, GFP_ATOMIC);
if (skb2 == NULL)
goto out;
m->tcf_bstats.bytes += qdisc_pkt_len(skb2);
m->tcf_bstats.packets++;
+ at = G_TC_AT(skb->tc_verd);
if (!(at & AT_EGRESS)) {
if (m->tcfm_ok_push)
skb_push(skb2, skb2->dev->hard_header_len);
for sch_generic.h was ok.
next prev parent reply other threads:[~2010-12-19 20:34 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-19 11:35 Kernel panic eth2 mirred redirect to ifb0 Paweł Staszewski
2010-12-19 11:39 ` Paweł Staszewski
2010-12-19 15:43 ` Eric Dumazet
2010-12-19 16:09 ` Paweł Staszewski
2010-12-19 16:22 ` Changli Gao
2010-12-19 20:34 ` Paweł Staszewski [this message]
2010-12-19 22:15 ` Jarek Poplawski
2010-12-19 22:21 ` Jarek Poplawski
2010-12-19 22:26 ` Jarek Poplawski
2010-12-20 8:01 ` Paweł Staszewski
2010-12-20 8:06 ` Eric Dumazet
2010-12-20 9:13 ` Paweł Staszewski
2010-12-20 8:56 ` Changli Gao
2010-12-20 9:08 ` Eric Dumazet
2010-12-20 9:11 ` Changli Gao
2010-12-20 9:21 ` Eric Dumazet
2010-12-20 10:32 ` Jarek Poplawski
2010-12-20 10:41 ` Eric Dumazet
2010-12-20 11:11 ` Jarek Poplawski
2010-12-20 11:58 ` Jarek Poplawski
2010-12-20 12:07 ` Paweł Staszewski
2010-12-20 12:22 ` Jarek Poplawski
2010-12-20 12:45 ` Eric Dumazet
2010-12-20 12:54 ` Eric Dumazet
2010-12-20 13:02 ` Jarek Poplawski
2010-12-20 14:05 ` Changli Gao
2010-12-20 14:25 ` [PATCH net-next-2.6] ifb: add performance flags to dev->features Eric Dumazet
2010-12-20 14:43 ` Changli Gao
2010-12-28 21:50 ` David Miller
2010-12-28 22:36 ` Eric Dumazet
2010-12-28 23:07 ` Jarek Poplawski
2011-01-02 20:24 ` [PATCH v2 net-next-2.6] ifb: add performance flags Eric Dumazet
2011-01-03 19:37 ` Jarek Poplawski
2011-01-03 19:40 ` David Miller
2011-01-03 20:35 ` Eric Dumazet
2011-01-03 20:40 ` David Miller
2010-12-20 12:30 ` Kernel panic eth2 mirred redirect to ifb0 Changli Gao
2010-12-20 13:37 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D0E6C6D.10806@itcare.pl \
--to=pstaszewski@itcare$(echo .)pl \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=xiaosuo@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox