From: Shan Wei <shanwei@cn•fujitsu.com>
To: David Miller <davem@davemloft•net>
Cc: albertpretorius@yahoo•co.uk, netdev@vger•kernel.org,
yoshfuji@linux-ipv6•org, pekkas@netcore•fi, jmorris@namei•org
Subject: Re: IPV6 loopback bound socket succeeds connecting to remote host
Date: Wed, 22 Dec 2010 15:06:24 +0800 [thread overview]
Message-ID: <4D11A370.9060901@cn.fujitsu.com> (raw)
In-Reply-To: <20101219.224350.260095315.davem@davemloft.net>
David Miller wrote, at 12/20/2010 02:43 PM:
> From: Shan Wei <shanwei@cn•fujitsu.com>
> Date: Mon, 20 Dec 2010 14:31:28 +0800
>
>> David Miller wrote, at 12/17/2010 04:18 AM:
>>> Your approach will only modify socket based route handling, it will
>>> not handle the ipv6 forwarding case which as per the quoted RFC
>>> sections must be handled too.
>>
>> For the ipv6 forwarding case, we have done the check in ip6_forward().
>>
>> 493 int addrtype = ipv6_addr_type(&hdr->saddr);
>> 494
>> 495 /* This check is security critical. */
>> 496 if (addrtype == IPV6_ADDR_ANY ||
>> 497 addrtype & (IPV6_ADDR_MULTICAST | IPV6_ADDR_LOOPBACK))
>> 498 goto error;
>
> Indeed, thanks for pointing this out.
Notice that the state in patchwork is “Changes Requested”, what should i do
now? I have no idead which part of this patch should be changed.
--
Best Regards
-----
Shan Wei
next prev parent reply other threads:[~2010-12-22 7:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-29 10:55 IPV6 loopback bound socket succeeds connecting to remote host Albert Pretorius
2010-12-01 8:18 ` Shan Wei
2010-12-02 7:45 ` Albert Pretorius
2010-12-02 8:41 ` Shan Wei
2010-12-16 20:18 ` David Miller
2010-12-20 6:31 ` Shan Wei
2010-12-20 6:43 ` David Miller
2010-12-22 7:06 ` Shan Wei [this message]
2010-12-29 16:53 ` Albert Pretorius
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D11A370.9060901@cn.fujitsu.com \
--to=shanwei@cn$(echo .)fujitsu.com \
--cc=albertpretorius@yahoo$(echo .)co.uk \
--cc=davem@davemloft$(echo .)net \
--cc=jmorris@namei$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pekkas@netcore$(echo .)fi \
--cc=yoshfuji@linux-ipv6$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox