Subject: Re: [net-next-2.6 PATCH v2 1/4] dcbnl: adding DCBX engine capability

From: John Fastabend <[email-masked]>
Date: Thu, 30 Dec 2010 11:09:20 -0800

On 12/30/2010 10:54 AM, John Fastabend wrote:
> On 12/30/2010 8:26 AM, Shmulik Ravid wrote:
>> Adding an optional DCBX capability and a pair for get-set routines for
>> setting the device DCBX mode. The DCBX capability is a bit field of
>> supported attributes. The user is expected to set the DCBX mode with a
>> subset of the advertised attributes.
>>
>> This patch is dependent on the following patches:
>> [net-next-2.6 PATCH 1/3] dcbnl: add support for ieee8021Qaz attributes
>> [net-next-2.6 PATCH 2/3] dcbnl: add appliction tlv handlers
>> [net-next-2.6 PATCH 3/3] net_dcb: add application notifiers
>>
>> Signed-off-by: Shmulik Ravid <[email-masked]>
>> ---
> 
> Acked-by: John Fastabend <[email-masked]>
> 
> Thanks for doing this Shmulik.
> 

Sorry missed this on my first pass.

>  
> +/* DCBX configuration */
> +static int dcbnl_getdcbx(struct net_device *netdev, struct nlattr **tb,
> +			 u32 pid, u32 seq, u16 flags)
> +{
> +	int ret = -EINVAL;
> +
> +	if (!netdev->dcbnl_ops->getdcbx)
> +		return ret;

I think we should actually return -EOPNOTSUPP here.

> +
> +	ret = dcbnl_reply(netdev->dcbnl_ops->getdcbx(netdev), RTM_GETDCB,
> +			  DCB_CMD_GDCBX, DCB_ATTR_DCBX, pid, seq, flags);
> +
> +	return ret;
> +}
> +