From: Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public•gmane.org>
To: Kurt Van Dijck <kurt.van.dijck-/BeEPy95v10@public•gmane.org>
Cc: socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public•gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
Subject: Re: [PATCH net-next-2.6 v2 1/2] can: add driver for Softing card
Date: Mon, 10 Jan 2011 15:07:25 +0100 [thread overview]
Message-ID: <4D2B129D.30908@grandegger.com> (raw)
In-Reply-To: <4D2B1245.9060303-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
On 01/10/2011 03:05 PM, Wolfgang Grandegger wrote:
> On 01/10/2011 02:31 PM, Kurt Van Dijck wrote:
>> Wolfgang,
>>
>> A few thoughts ...
>>
>> On Wed, Jan 05, 2011 at 09:57:16PM +0100, Wolfgang Grandegger wrote:
>>>>
>>>> obj-y += usb/
>>>> +obj-y += softing/
>>>
>>> Please use "obj-$(CONFIG_CAN_SOFTING)" here.
>> As I explained, softing does not depend on softing_cs or vice versa,
>> which makes "obj-$(CONFIG_CAN_SOFTING)" not right.
>
> OK, another good reason to make softing_cs depend on CONFIG_CAN_SOFTING.
> Does it make sense to compile softing_cs without CONFIG_CAN_SOFTING for
> the *real* user?
>
> ...
>
>>>> + priv->can.ctrlmode_supported =
>>>> + CAN_CTRLMODE_3_SAMPLES;/* | CAN_CTRLMODE_BERR_REPORTING */;
>>>
>>> Hm, any chance to support CAN_CTRLMODE_BERR_REPORTING? If not, please
>>> remove the comment.
>>
>> I think I better try to write it properly without, and add error reporting
>> later, after serious testing of the error reporting on a softing card.
>
> OK, then just cleanup properly.
>
>> The primary goal now is get this driver in mainline kernel since PCMCIA
>> has been changing recently, and I found it hard to keep up. So, first things
>> first ...
>
> Fine for me. You can then add my:
>
> Acked-by: Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public•gmane.org>
Is there a mailing list for the PCMCIA interface? If yes, please add it
to the CC as well.
Wolfgang.
next prev parent reply other threads:[~2011-01-10 14:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-04 15:05 [PATCH net-next-2.6 v2 0/2] can: add driver for Softing card Kurt Van Dijck
[not found] ` <20110104150513.GA321-MxZ6Iy/zr/UdbCeoMzGj59i2O/JbrIOy@public.gmane.org>
2011-01-04 15:07 ` [PATCH net-next-2.6 v2 1/2] " Kurt Van Dijck
[not found] ` <20110104150759.GB321-MxZ6Iy/zr/UdbCeoMzGj59i2O/JbrIOy@public.gmane.org>
2011-01-05 20:57 ` Wolfgang Grandegger
2011-01-06 15:05 ` Kurt Van Dijck
[not found] ` <20110106150525.GB324-MxZ6Iy/zr/UdbCeoMzGj59i2O/JbrIOy@public.gmane.org>
2011-01-06 16:27 ` Wolfgang Grandegger
[not found] ` <4D25ED70.7000303-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2011-01-07 12:29 ` Kurt Van Dijck
[not found] ` <4D24DB2C.9040104-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2011-01-10 13:31 ` Kurt Van Dijck
[not found] ` <20110110133112.GA324-MxZ6Iy/zr/UdbCeoMzGj59i2O/JbrIOy@public.gmane.org>
2011-01-10 13:40 ` Wolfram Sang
[not found] ` <20110110134006.GC31011-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-01-10 13:44 ` Kurt Van Dijck
2011-01-10 14:05 ` Wolfgang Grandegger
[not found] ` <4D2B1245.9060303-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2011-01-10 14:07 ` Wolfgang Grandegger [this message]
2011-01-10 14:40 ` Kurt Van Dijck
2011-01-04 15:09 ` [PATCH net-next-2.6 v2 2/2] " Kurt Van Dijck
[not found] ` <20110104150923.GC321-MxZ6Iy/zr/UdbCeoMzGj59i2O/JbrIOy@public.gmane.org>
2011-01-05 21:02 ` Wolfgang Grandegger
[not found] ` <4D24DC58.7090009-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2011-01-06 6:26 ` Kurt Van Dijck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2B129D.30908@grandegger.com \
--to=wg-5yr1bzd7o62+xt7jha+gda@public$(echo .)gmane.org \
--cc=kurt.van.dijck-/BeEPy95v10@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox