From: Greg Ungerer <gerg@snapgear•com>
To: Sascha Hauer <s.hauer@pengutronix•de>
Cc: Shawn Guo <shawn.guo@freescale•com>, <B32542@freescale•com>,
<netdev@vger•kernel.org>, <u.kleine-koenig@pengutronix•de>,
<jamie@shareable•org>, <baruch@tkos•co.il>,
<w.sang@pengutronix•de>, <r64343@freescale•com>,
<eric@eukrea•com>, <bryan.wu@canonical•com>,
<jamie@jamieiles•com>, <davem@davemloft•net>,
<linux-arm-kernel@lists•infradead.org>, <lw@karo-electronics•de>
Subject: Re: [PATCH v4 05/10] net/fec: add dual fec support for mx28
Date: Tue, 11 Jan 2011 22:24:12 +1000 [thread overview]
Message-ID: <4D2C4BEC.1030003@snapgear.com> (raw)
In-Reply-To: <20110111102717.GG26617@pengutronix.de>
On 11/01/11 20:27, Sascha Hauer wrote:
> On Thu, Jan 06, 2011 at 03:13:13PM +0800, Shawn Guo wrote:
>> This patch is to add mx28 dual fec support. Here are some key notes
>> for mx28 fec controller.
>>
>> - The mx28 fec controller naming ENET-MAC is a different IP from FEC
>> used on other i.mx variants. But they are basically compatible
>> on software interface, so it's possible to share the same driver.
>> - ENET-MAC design on mx28 made an improper assumption that it runs
>> on a big-endian system. As the result, driver has to swap every
>> frame going to and coming from the controller.
>> - The external phys can only be configured by fec0, which means fec1
>> can not work independently and both phys need to be configured by
>> mii_bus attached on fec0.
>> - ENET-MAC reset will get mac address registers reset too.
>> - ENET-MAC MII/RMII mode and 10M/100M speed are configured
>> differently FEC.
>> - ETHER_EN bit must be set to get ENET-MAC interrupt work.
>>
>> Signed-off-by: Shawn Guo<shawn.guo@freescale•com>
>> ---
>> Changes for v4:
>> - Use #ifndef CONFIG_ARM to include ColdFire header files
>> - Define quirk bits in id_entry.driver_data to handle controller
>> difference, which is more scalable than using device name
>> - Define fec0_mii_bus as a static function in fec_enet_mii_init
>> to fold the mii_bus instance attached on fec0
>> - Use cpu_to_be32 over __swab32 in function swap_buffer
>>
>> Changes for v3:
>> - Move v2 changes into patch #3
>> - Use device name to check if it's running on ENET-MAC
>>
>> drivers/net/Kconfig | 7 ++-
>> drivers/net/fec.c | 148 +++++++++++++++++++++++++++++++++++++++++++++------
>> drivers/net/fec.h | 5 +-
>> 3 files changed, 139 insertions(+), 21 deletions(-)
>>
>> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
>> index 4f1755b..f34629b 100644
>> --- a/drivers/net/Kconfig
>> +++ b/drivers/net/Kconfig
>> @@ -1944,18 +1944,19 @@ config 68360_ENET
>> config FEC
>> bool "FEC ethernet controller (of ColdFire and some i.MX CPUs)"
>> depends on M523x || M527x || M5272 || M528x || M520x || M532x || \
>> - MACH_MX27 || ARCH_MX35 || ARCH_MX25 || ARCH_MX5
>> + MACH_MX27 || ARCH_MX35 || ARCH_MX25 || ARCH_MX5 || SOC_IMX28
>> select PHYLIB
>> help
>> Say Y here if you want to use the built-in 10/100 Fast ethernet
>> controller on some Motorola ColdFire and Freescale i.MX processors.
>>
>> config FEC2
>> - bool "Second FEC ethernet controller (on some ColdFire CPUs)"
>> + bool "Second FEC ethernet controller"
>> depends on FEC
>> help
>> Say Y here if you want to use the second built-in 10/100 Fast
>> - ethernet controller on some Motorola ColdFire processors.
>> + ethernet controller on some Motorola ColdFire and Freescale
>> + i.MX processors.
>
> This option is used nowhere and should be removed. Certainly it does not
> have the effect of enabling the second ethernet controller.
It does for a ColdFire platform...
grep -r CONFIG_FEC2 *
arch/m68knommu/configs/m5275evb_defconfig:CONFIG_FEC2=y
arch/m68knommu/platform/527x/config.c:#ifdef CONFIG_FEC2
arch/m68knommu/platform/527x/config.c:#ifdef CONFIG_FEC2
Regards
Greg
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear•com
SnapGear Group, McAfee PHONE: +61 7 3435 2888
8 Gardner Close, FAX: +61 7 3891 3630
Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com
next prev parent reply other threads:[~2011-01-11 12:26 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-06 7:13 [PATCH v4 00/10] net/fec: add dual fec support for i.MX28 Shawn Guo
2011-01-06 7:13 ` [PATCH v4 01/10] net/fec: fix MMFR_OP type in fec_enet_mdio_write Shawn Guo
2011-01-06 7:13 ` [PATCH v4 02/10] net/fec: remove the use of "index" which is legacy Shawn Guo
2011-01-06 7:13 ` [PATCH v4 03/10] net/fec: add mac field into platform data and consolidate fec_get_mac Shawn Guo
2011-01-06 7:13 ` [PATCH v4 04/10] net/fec: improve pm for better suspend/resume Shawn Guo
2011-01-06 7:13 ` [PATCH v4 05/10] net/fec: add dual fec support for mx28 Shawn Guo
2011-01-11 10:27 ` Sascha Hauer
2011-01-11 11:38 ` Shawn Guo
2011-01-11 12:24 ` Greg Ungerer [this message]
2011-01-11 13:07 ` Uwe Kleine-König
2011-01-11 13:25 ` Greg Ungerer
2011-01-12 7:42 ` Uwe Kleine-König
2011-01-13 14:48 ` Uwe Kleine-König
2011-01-14 5:48 ` Shawn Guo
2011-01-14 7:52 ` Uwe Kleine-König
2011-01-14 13:08 ` Shawn Guo
2011-01-17 8:16 ` Lothar Waßmann
2011-01-17 8:42 ` Uwe Kleine-König
2011-01-17 11:52 ` Shawn Guo
2011-01-17 9:06 ` Uwe Kleine-König
2011-01-13 21:06 ` Uwe Kleine-König
2011-01-06 7:13 ` [PATCH v4 06/10] ARM: mx28: update clock and device name for dual fec support Shawn Guo
2011-01-13 15:06 ` Uwe Kleine-König
2011-01-14 6:46 ` Shawn Guo
2011-01-14 6:53 ` [PATCH] ARM: mxs: pass fec device name via platform data Shawn Guo
2011-01-14 8:38 ` Uwe Kleine-König
2011-01-06 7:13 ` [PATCH v4 07/10] ARM: mx28: add the second fec device registration Shawn Guo
2011-01-11 10:29 ` Sascha Hauer
2011-01-11 11:39 ` Shawn Guo
2011-01-11 11:44 ` Sascha Hauer
2011-01-06 7:13 ` [PATCH v4 08/10] ARM: mxs: add ocotp read function Shawn Guo
2011-01-11 13:31 ` Sascha Hauer
2011-01-11 14:05 ` Uwe Kleine-König
2011-01-12 6:47 ` Shawn Guo
2011-01-12 14:50 ` Sascha Hauer
2011-01-12 16:01 ` Uwe Kleine-König
2011-01-13 1:55 ` Shawn Guo
2011-01-13 15:19 ` Uwe Kleine-König
2011-01-14 8:33 ` Sascha Hauer
2011-01-14 13:16 ` Shawn Guo
2011-01-19 10:48 ` Shawn Guo
2011-01-06 7:13 ` [PATCH v4 09/10] ARM: mx28: read fec mac address from ocotp Shawn Guo
2011-01-13 14:50 ` Uwe Kleine-König
2011-01-06 7:13 ` [PATCH v4 10/10] ARM: mxs: add initial pm support Shawn Guo
2011-01-09 23:44 ` [PATCH v4 00/10] net/fec: add dual fec support for i.MX28 David Miller
2011-01-10 3:08 ` Shawn Guo
2011-01-11 8:15 ` Shawn Guo
2011-01-11 12:07 ` [PATCH] net/fec: remove config FEC2 as it's used nowhere Shawn Guo
2011-01-11 22:03 ` David Miller
2011-01-11 12:09 ` [PATCH v5] ARM: mx28: add the second fec device registration Shawn Guo
2011-01-13 14:49 ` Uwe Kleine-König
2011-01-14 7:04 ` Shawn Guo
2011-01-14 7:24 ` [PATCH v5 08/10] ARM: mxs: add ocotp read function Shawn Guo
2011-01-14 8:40 ` Sascha Hauer
2011-01-14 9:48 ` Uwe Kleine-König
2011-01-14 8:42 ` Uwe Kleine-König
2011-01-14 7:25 ` [PATCH v5 09/10] ARM: mxs/mx28evk: read fec mac address from ocotp Shawn Guo
2011-01-14 15:11 ` [PATCH v6 08/10] ARM: mxs: add ocotp read function Shawn Guo
2011-01-24 9:05 ` [PATCH v5] ARM: mxs: add initial pm support Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2C4BEC.1030003@snapgear.com \
--to=gerg@snapgear$(echo .)com \
--cc=B32542@freescale$(echo .)com \
--cc=baruch@tkos$(echo .)co.il \
--cc=bryan.wu@canonical$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=eric@eukrea$(echo .)com \
--cc=jamie@jamieiles$(echo .)com \
--cc=jamie@shareable$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=lw@karo-electronics$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=r64343@freescale$(echo .)com \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=shawn.guo@freescale$(echo .)com \
--cc=u.kleine-koenig@pengutronix$(echo .)de \
--cc=w.sang@pengutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox