From: Daniel Hellstrom <daniel@gaisler•com>
To: David Miller <davem@davemloft•net>
Cc: netdev@vger•kernel.org, kristoffer@gaisler•com
Subject: Re: [PATCH 02/10] GRETH: added option to disable a device node from bootloader.
Date: Fri, 14 Jan 2011 08:45:48 +0100 [thread overview]
Message-ID: <4D2FFF2C.3050904@gaisler.com> (raw)
In-Reply-To: <20110113.221238.97339127.davem@davemloft.net>
David Miller wrote:
>From: Daniel Hellstrom <daniel@gaisler•com>
>Date: Thu, 13 Jan 2011 09:25:27 +0100
>
>
>
>>Signed-off-by: Daniel Hellstrom <daniel@gaisler•com>
>>
>>
>
>This is not how you do this.
>
>Simply not present the device in the OpenFirmware tree at all. If you
>can make this special properly appear, you can also toss the device
>node away completely.
>
>There is zero reason whatsoever to create a special hack-job
>non-standardized device node properly to do this.
>
>
I agree, I will remove it. The optional parameter should be a setting
for a particular device rather that a "disable device" parameter.
Thanks,
Daniel
next prev parent reply other threads:[~2011-01-14 7:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-13 8:25 [PATCH 01/10] GRETH: added raw AMBA vendor/device number to match against Daniel Hellstrom
2011-01-13 8:25 ` [PATCH 02/10] GRETH: added option to disable a device node from bootloader Daniel Hellstrom
2011-01-14 6:12 ` David Miller
2011-01-14 7:45 ` Daniel Hellstrom [this message]
2011-01-13 8:25 ` [PATCH 03/10] GRETH: added no_gbit option Daniel Hellstrom
2011-01-14 6:13 ` David Miller
2011-01-14 7:51 ` Daniel Hellstrom
2011-01-13 8:25 ` [PATCH 04/10] GRETH: added greth_compat_mode module parameter Daniel Hellstrom
2011-01-14 6:14 ` David Miller
2011-01-14 8:10 ` Daniel Hellstrom
2011-01-13 8:25 ` [PATCH 05/10] GRETH: fix opening/closing Daniel Hellstrom
2011-01-13 8:25 ` [PATCH 06/10] GRETH: GBit transmit descriptor handling optimization Daniel Hellstrom
2011-01-13 8:25 ` [PATCH 07/10] GRETH: fixed skb buffer memory leak on frame errors Daniel Hellstrom
2011-01-13 8:25 ` [PATCH 08/10] GRETH: avoid writing bad speed/duplex when setting transfer mode Daniel Hellstrom
2011-01-13 8:25 ` [PATCH 09/10] GRETH: handle frame error interrupts Daniel Hellstrom
2011-01-13 8:25 ` [PATCH 10/10] GRETH: resolve SMP issues and other problems Daniel Hellstrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2FFF2C.3050904@gaisler.com \
--to=daniel@gaisler$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=kristoffer@gaisler$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox