Subject: Re: [PATCH] sctp: user perfect name for Delayed SACK Timer option

From: Wei Yongjun <[email-masked]>
Date: Wed, 19 Jan 2011 16:22:52 +0800

> David Miller wrote, at 01/19/2011 03:39 PM:
>> From: Shan Wei <[email-masked]>
>> Date: Wed, 19 Jan 2011 15:33:30 +0800
>>
>>> The option name of Delayed SACK Timer should be SCTP_DELAYED_SACK,
>>> not SCTP_DELAYED_ACK.
>>>
>>> Reference:
>>> 8.1.19.  Get or Set Delayed SACK Timer (SCTP_DELAYED_SACK)
>>> （http://tools.ietf.org/html/draft-ietf-tsvwg-sctpsocket-25)
>>>
>>>
>>> Signed-off-by: Shan Wei <[email-masked]>
>> You can't make this change, you'll break applications using the
>> existing definition.
> No documents guide user to use SCTP_DELAYED_ACK option.
> I double that there is no applications using this option.
>
> If, there be. How about keeping this be concomitant with SCTP_DELAYED_SACK?

You sould do as the same as the following patch, which has fixed the same
problem of lksctp-tools, but not lksctp:

http://git.kernel.org/?p=linux/kernel/git/vxy/lksctp-tools.git;a=commit;h=ecdc6c0d3c3e40843916427923a45a93d748c1c6