public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Shan Wei <shanwei@cn•fujitsu.com>
To: "David Miller" <davem@davemloft•net>,
	"Vlad Yasevich" <vladislav.yasevich@hp•com>,
	魏勇军 <yjwei@cn•fujitsu.com>,
	Network-Maillist <netdev@vger•kernel.org>
Subject: [PATCH-v2] sctp: user perfect name for Delayed SACK Timer option
Date: Wed, 19 Jan 2011 16:39:00 +0800	[thread overview]
Message-ID: <4D36A324.4040307@cn.fujitsu.com> (raw)
In-Reply-To: <4D3693CA.40508@cn.fujitsu.com>

The option name of Delayed SACK Timer should be SCTP_DELAYED_SACK,
not SCTP_DELAYED_ACK.

Left SCTP_DELAYED_ACK be concomitant with SCTP_DELAYED_SACK,
for making compatibility with existing applications.

Reference:
8.1.19.  Get or Set Delayed SACK Timer (SCTP_DELAYED_SACK)
（http://tools.ietf.org/html/draft-ietf-tsvwg-sctpsocket-25)

Signed-off-by: Shan Wei <shanwei@cn•fujitsu.com>
---
 include/net/sctp/user.h |    1 +
 net/sctp/socket.c       |    4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/include/net/sctp/user.h b/include/net/sctp/user.h
index 2b2769c..92eedc0 100644
--- a/include/net/sctp/user.h
+++ b/include/net/sctp/user.h
@@ -78,6 +78,7 @@ typedef __s32 sctp_assoc_t;
 #define SCTP_GET_PEER_ADDR_INFO	15
 #define SCTP_DELAYED_ACK_TIME	16
 #define SCTP_DELAYED_ACK SCTP_DELAYED_ACK_TIME
+#define SCTP_DELAYED_SACK SCTP_DELAYED_ACK_TIME
 #define SCTP_CONTEXT	17
 #define SCTP_FRAGMENT_INTERLEAVE	18
 #define SCTP_PARTIAL_DELIVERY_POINT	19 /* Set/Get partial delivery point */
diff --git a/net/sctp/socket.c b/net/sctp/socket.c
index a09b0dd..8e02550 100644
--- a/net/sctp/socket.c
+++ b/net/sctp/socket.c
@@ -3428,7 +3428,7 @@ SCTP_STATIC int sctp_setsockopt(struct sock *sk, int level, int optname,
 		retval = sctp_setsockopt_peer_addr_params(sk, optval, optlen);
 		break;
 
-	case SCTP_DELAYED_ACK:
+	case SCTP_DELAYED_SACK:
 		retval = sctp_setsockopt_delayed_ack(sk, optval, optlen);
 		break;
 	case SCTP_PARTIAL_DELIVERY_POINT:
@@ -5333,7 +5333,7 @@ SCTP_STATIC int sctp_getsockopt(struct sock *sk, int level, int optname,
 		retval = sctp_getsockopt_peer_addr_params(sk, len, optval,
 							  optlen);
 		break;
-	case SCTP_DELAYED_ACK:
+	case SCTP_DELAYED_SACK:
 		retval = sctp_getsockopt_delayed_ack(sk, len, optval,
 							  optlen);
 		break;
-- 
1.6.3.3

next prev parent reply	other threads:[~2011-01-19  8:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-19  7:33 [PATCH] sctp: user perfect name for Delayed SACK Timer option Shan Wei
2011-01-19  7:39 ` David Miller
2011-01-19  8:17   ` Shan Wei
2011-01-19  8:22     ` Wei Yongjun
2011-01-19  8:39 ` Shan Wei [this message]
2011-01-19  8:48   ` [PATCH-v2] " Wei Yongjun
2011-01-19  8:54     ` Shan Wei
2011-01-19 13:37   ` Vladislav Yasevich
2011-01-20  0:51     ` David Miller

find likely ancestor, descendant, or conflicting patches for this message:
( dfblob:2b2769c dfblob:92eedc0 dfblob:a09b0dd dfblob:8e02550 )
 OR (
bs:"[PATCH-v2] sctp: user perfect name for Delayed SACK Timer option" )
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D36A324.4040307@cn.fujitsu.com \
    --to=shanwei@cn$(echo .)fujitsu.com \
    --cc=davem@davemloft$(echo .)net \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=vladislav.yasevich@hp$(echo .)com \
    --cc=yjwei@cn$(echo .)fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox