Subject: Re: [PATCH 00/79] netfilter: netfilter update

From: Patrick McHardy <[email-masked]>
Date: Thu, 20 Jan 2011 02:13:31 +0100

On 20.01.2011 01:50, David Miller wrote:
> I'm undoing my pull, what was this build tested against?

My build tests didn't include header-install. No idea what Jan
tested against.

> In particular this commit breaks the build:
> 
> Subject: [PATCH 68/79] netfilter: xtables: add missing header files to export list
> 
> Signed-off-by: Jan Engelhardt <[email-masked]>
>  ...
> @@ -56,6 +56,8 @@ header-y += xt_rateest.h
>  header-y += xt_realm.h
>  header-y += xt_recent.h
>  header-y += xt_sctp.h
> +header-y += xt_secmark.h
> +header-y += xt_socket.h
>  header-y += xt_state.h
>  header-y += xt_statistic.h
>  header-y += xt_string.h
> 
> No active tree has a include/linux/netfilter/xt_secmark.h file.  Therefore
> we end up with:
> 
> make[2]: `scripts/unifdef' is up to date.
> make[4]: *** No rule to make target `/home/davem/src/GIT/net-next-2.6/include/linux/netfilter/xt_secmark.h', needed by `/home/davem/src/GIT/net-next-2.6/usr/include/linux/netfilter/.install'.  Stop.
> 
> Did you mean xt_SECMARK.h (caps)?

I guess so. Jan, please fix this up.