From: Wolfgang Grandegger <wg@grandegger•com>
To: Marc Kleine-Budde <mkl@pengutronix•de>
Cc: Bhupesh Sharma <bhupesh.sharma@st•com>,
socketcan-core@lists•berlios.de, netdev@vger•kernel.org
Subject: Re: [PATCH net-next-2.6 v6 1/1] can: c_can: Added support for Bosch C_CAN controller
Date: Wed, 09 Feb 2011 11:41:30 +0100 [thread overview]
Message-ID: <4D526F5A.6030706@grandegger.com> (raw)
In-Reply-To: <4D525DF8.6050409@pengutronix.de>
Hi Marc,
On 02/09/2011 10:27 AM, Marc Kleine-Budde wrote:
> On 02/09/2011 06:03 AM, Bhupesh Sharma wrote:
>> + if (flags & IF_ARB_TRANSMIT)
>> + frame->can_id |= CAN_RTR_FLAG;
>
> Can you please only copy the data to the frame if the rtr flag isn't
> set. Not all driver do this yet, but we've agreed to do so.
Yes, I remember the patch
[PATCH v2 0/9] can: don't copy data to rx'ed RTR frames
What happend with it?
Wolfgang.
next prev parent reply other threads:[~2011-02-09 10:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-09 5:03 [PATCH net-next-2.6 v6 1/1] can: c_can: Added support for Bosch C_CAN controller Bhupesh Sharma
[not found] ` <1297227821-18021-1-git-send-email-bhupesh.sharma-qxv4g6HH51o@public.gmane.org>
2011-02-09 9:27 ` Marc Kleine-Budde
[not found] ` <4D525DF8.6050409-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-02-09 10:31 ` Bhupesh SHARMA
2011-02-09 10:41 ` Wolfgang Grandegger [this message]
[not found] ` <4D526F5A.6030706-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2011-02-09 10:46 ` Marc Kleine-Budde
-- strict thread matches above, loose matches on Subject: below --
2011-02-09 10:54 Bhupesh SHARMA
[not found] ` <D5ECB3C7A6F99444980976A8C6D896384DEE36615D-8vAmw3ZAcdzhJTuQ9jeba9BPR1lH4CV8@public.gmane.org>
2011-02-10 9:28 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D526F5A.6030706@grandegger.com \
--to=wg@grandegger$(echo .)com \
--cc=bhupesh.sharma@st$(echo .)com \
--cc=mkl@pengutronix$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=socketcan-core@lists$(echo .)berlios.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox