From: Dimitris Michailidis <dm@chelsio•com>
To: Tom Herbert <therbert@google•com>
Cc: davem@davemloft•net, netdev@vger•kernel.org
Subject: Re: [PATCH 1/2] net: Add RX queue weights
Date: Fri, 11 Feb 2011 19:49:36 -0800 [thread overview]
Message-ID: <4D560350.5080002@chelsio.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1102111552090.2793@pokey.mtv.corp.google.com>
Tom Herbert wrote:
> This patch adds a weight attribute to the netdev RX queues. This allows
> control over the relative receive packet load for each queue. These
> values are set in sysfs variable 'weight' in the rxq directory for
> a device. When a weight is set, a new netdev operation is called to
> inform the driver of the changed weight. The driver is expected to
> apply the queue weights in a logical manner to the RSS indirection table
> of the device to achieve the desired weighting. The driver
> implementation for this is unspecified.
>
> If a weight for a queue is zero, this effectively disables that queue
> for RSS (but possibly still usable by accelerated RFS, etc.), except
> in the case that all queue weights are zero, then all queues are
> considered equally weighted (the default).
>
> Example configuration:
> echo 1 > /sys/class/net/eth4/queues/rx-0/weight
> echo 1 > /sys/class/net/eth4/queues/rx-1/weight
> echo 5 > /sys/class/net/eth4/queues/rx-2/weight
> echo 0 > /sys/class/net/eth4/queues/rx-3/weight
>
> So rx queue 0 and 1 have equal weight, queue 2 is 5X in weight and
> queue 3 is disabled for RSS.
Doesn't ethtool -X already do this? With the added benefit that ethtool
doesn't need each driver to provide its own weight handling arithmetic.
next prev parent reply other threads:[~2011-02-12 3:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-12 0:00 [PATCH 1/2] net: Add RX queue weights Tom Herbert
2011-02-12 3:49 ` Dimitris Michailidis [this message]
2011-02-12 5:32 ` Tom Herbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D560350.5080002@chelsio.com \
--to=dm@chelsio$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=therbert@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox