Subject: Re: [PATCH net-next-2.6 v7 1/1] can: c_can: Added support for Bosch C_CAN controller

From: Wolfgang Grandegger <[email-masked]>
Date: Sat, 12 Feb 2011 15:24:42 +0100

On 02/11/2011 11:17 AM, Bhupesh Sharma wrote:
> Bosch C_CAN controller is a full-CAN implementation which is compliant
> to CAN protocol version 2.0 part A and B. Bosch C_CAN user manual can be
> obtained from:
> http://www.semiconductors.bosch.de/media/en/pdf/ipmodules_1/
> c_can/users_manual_c_can.pdf
> 
> This patch adds the support for this controller.
> The following are the design choices made while writing the controller
> driver:
> 1. Interface Register set IF1 has be used only in the current design.
> 2. Out of the 32 Message objects available, 16 are kept aside for RX
>    purposes and the rest for TX purposes.
> 3. NAPI implementation is such that both the TX and RX paths function
>    in polling mode.
> 
> Signed-off-by: Bhupesh Sharma <[email-masked]>
> ---
> Changes since V6:
> 1. Added check for calling netif_stop_queue() in case next TX object
>    is busy.
> 2. Added logic *not* to copy data to rx'ed RTR frames.
> 3. Moved enums, defines and structs present in c_can.h file to the respective
>    c-file where they are actually used.
> 4. Corrected message object busy status routine by using a better name
>    and design approach.
> 5. Moved *set_bittiming* call to the *c_can_chip_config* function.

Acked-by: Wolfgang Grandegger <[email-masked]>

Thanks for your contribution. As soon as the patch is accepted, I will
send a patch for the PCH CAN.

Wolfgang.