From: Patrick McHardy <kaber@trash•net>
To: Jiri Pirko <jpirko@redhat•com>
Cc: netdev@vger•kernel.org, davem@davemloft•net,
shemminger@linux-foundation•org, fubar@us•ibm.com,
eric.dumazet@gmail•com, nicolas.2p.debian@gmail•com
Subject: Re: [patch net-next-2.6 1/4] rtnetlink: implement setting of master device
Date: Sun, 13 Feb 2011 20:43:35 +0100 [thread overview]
Message-ID: <4D583467.6020803@trash.net> (raw)
In-Reply-To: <20110213193105.GD2740@psychotron.redhat.com>
Am 13.02.2011 20:31, schrieb Jiri Pirko:
> This patch allows userspace to enslave/release slave devices via netlink
> interface using IFLA_MASTER. This introduces generic way to add/remove
> underling devices.
Looks good to me, just one question:
> @@ -1301,6 +1337,12 @@ static int do_setlink(struct net_device *dev, struct ifinfomsg *ifm,
> goto errout;
> }
>
> + if (tb[IFLA_MASTER]) {
> + err = do_set_master(dev, nla_get_u32(tb[IFLA_MASTER]));
> + if (err)
> + goto errout;
> + }
Any reason why you're not setting "modified" here?
> +
> if (tb[IFLA_TXQLEN])
> dev->tx_queue_len = nla_get_u32(tb[IFLA_TXQLEN]);
>
next prev parent reply other threads:[~2011-02-13 19:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-13 19:31 [patch net-next-2.6 1/4] rtnetlink: implement setting of master device Jiri Pirko
2011-02-13 19:32 ` [patch iproute2 2/4] iplink: " Jiri Pirko
2011-02-13 19:33 ` [patch net-next-2.6 3/4] bond: implement [add/del]_slave ops Jiri Pirko
2011-02-14 0:58 ` David Miller
2011-02-13 19:33 ` [patch net-next-2.6 4/4] bridge: " Jiri Pirko
2011-02-14 0:59 ` David Miller
2011-02-16 13:21 ` Stephen Hemminger
2011-02-13 19:43 ` Patrick McHardy [this message]
2011-02-13 20:15 ` [patch net-next-2.6 1/4] rtnetlink: implement setting of master device Jiri Pirko
2011-02-13 20:16 ` Patrick McHardy
2011-02-14 0:58 ` David Miller
2011-02-16 13:18 ` Stephen Hemminger
2011-02-16 14:39 ` Jiri Pirko
2011-02-16 15:25 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D583467.6020803@trash.net \
--to=kaber@trash$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=fubar@us$(echo .)ibm.com \
--cc=jpirko@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nicolas.2p.debian@gmail$(echo .)com \
--cc=shemminger@linux-foundation$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox