From: Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public•gmane.org>
To: Subhasish Ghosh
<subhasish-EvXpCiN+lbve9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
Cc: sachi-EvXpCiN+lbve9wHmmfpqLFaTQe2KTcn/@public.gmane.org,
davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org,
CAN NETWORK DRIVERS
<netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
nsekhar-l0cyMroinI0@public•gmane.org,
open list <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
CAN NETWORK DRIVERS
<socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public•gmane.org>,
Marc Kleine-Budde <mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public•gmane.org>,
m-watkins-l0cyMroinI0@public•gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public•gmane.org
Subject: Re: [PATCH v2 09/13] can: pruss CAN driver.
Date: Mon, 14 Feb 2011 14:42:00 +0100 [thread overview]
Message-ID: <4D593128.8090807@grandegger.com> (raw)
In-Reply-To: <8CB9F2C8F75C4041B9F0691D209DDAFD@subhasishg>
On 02/14/2011 02:15 PM, Subhasish Ghosh wrote:
> Hello,
>
> The problem with the "all" implementation is that it hogs the ARM/DSP
> heavily and that's the reason why we specifically avoided this in our
> firmware design.
> Hence, implementing this condition spoils the whole purpose of the PRU!!
Well, I doubt that a CAN controller just supporting 8 CAN identifiers
will make many CAN users happy. Anyway, the CAN identifiers could/should
be configured via SysFS files (as Marc suggested).
Wolfgang.
> --------------------------------------------------
> From: "Marc Kleine-Budde" <mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public•gmane.org>
> Sent: Monday, February 14, 2011 3:05 PM
> To: "Subhasish Ghosh" <subhasish-EvXpCiN+lbve9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
> Cc: "Wolfgang Grandegger" <wg-5Yr1BZd7O62+XT7JhA+gdA@public•gmane.org>; "Kurt Van Dijck"
> <kurt.van.dijck-/BeEPy95v10@public•gmane.org>;
> <davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org>;
> <linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public•gmane.org>; <m-watkins-l0cyMroinI0@public•gmane.org>;
> <nsekhar-l0cyMroinI0@public•gmane.org>; <sachi-EvXpCiN+lbve9wHmmfpqLFaTQe2KTcn/@public.gmane.org>; "open list:CAN NETWORK
> DRIVERS" <socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public•gmane.org>; "open list:CAN NETWORK
> DRIVERS" <netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>; "open list"
> <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>
> Subject: Re: [PATCH v2 09/13] can: pruss CAN driver.
>
> Hello,
>
> On 02/14/2011 09:45 AM, Subhasish Ghosh wrote:
>> That is correct, we receive only pre-programmed CAN ids and "all" or
>> "range" implementation is not there in the PRU firmware.
>
> I'd really like to see that you add a "all" implementation to the
> firmware. Or even better use the standard id/mask approach.
>
> cheers, Marc
>
next prev parent reply other threads:[~2011-02-14 13:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1297435892-28278-1-git-send-email-subhasish@mistralsolutions.com>
2011-02-11 14:51 ` [PATCH v2 09/13] can: pruss CAN driver Subhasish Ghosh
[not found] ` <1297435892-28278-10-git-send-email-subhasish-EvXpCiN+lbve9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
2011-02-11 15:06 ` Kurt Van Dijck
2011-02-14 4:54 ` Subhasish Ghosh
2011-02-14 7:23 ` Wolfgang Grandegger
[not found] ` <4D58D854.5090503-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2011-02-14 7:42 ` Kurt Van Dijck
2011-02-14 8:45 ` Subhasish Ghosh
2011-02-14 9:28 ` Wolfgang Grandegger
2011-02-14 9:35 ` Marc Kleine-Budde
[not found] ` <4D58F77B.9080005-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-02-14 13:15 ` Subhasish Ghosh
2011-02-14 13:33 ` Marc Kleine-Budde
2011-02-14 13:42 ` Wolfgang Grandegger [this message]
2011-02-11 15:20 ` Kurt Van Dijck
[not found] ` <20110211152026.GC373-MxZ6Iy/zr/UdbCeoMzGj59i2O/JbrIOy@public.gmane.org>
2011-02-18 7:07 ` Subhasish Ghosh
2011-02-18 7:53 ` Wolfgang Grandegger
[not found] ` <4D5E2570.10108-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2011-02-18 8:15 ` Subhasish Ghosh
2011-02-18 8:36 ` Marc Kleine-Budde
[not found] ` <4D5E2F86.1020400-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-02-18 9:09 ` Subhasish Ghosh
2011-02-11 20:33 ` Wolfgang Grandegger
2011-02-11 21:33 ` Marc Kleine-Budde
2011-02-18 15:07 ` Arnd Bergmann
[not found] ` <201102181607.20787.arnd-r2nGTMty4D4@public.gmane.org>
2011-03-22 7:30 ` Subhasish Ghosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D593128.8090807@grandegger.com \
--to=wg-5yr1bzd7o62+xt7jha+gda@public$(echo .)gmane.org \
--cc=davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public$(echo .)gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=m-watkins-l0cyMroinI0@public$(echo .)gmane.org \
--cc=mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=nsekhar-l0cyMroinI0@public$(echo .)gmane.org \
--cc=sachi-EvXpCiN+lbve9wHmmfpqLFaTQe2KTcn/@public.gmane.org \
--cc=socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public$(echo .)gmane.org \
--cc=subhasish-EvXpCiN+lbve9wHmmfpqLFaTQe2KTcn/@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox