From: Bernard Pidoux <bernard.pidoux@upmc•fr>
To: Linux Netdev List <netdev@vger•kernel.org>
Cc: ralf@linux-mips•org, davem@davemloft•net,
Bernard Pidoux F6BVP <f6bvp@free•fr>
Subject: Re: [PATCH] [ROSE] AX25 packet routing improvement
Date: Mon, 14 Feb 2011 18:52:09 +0100 [thread overview]
Message-ID: <4D596BC9.4030509@upmc.fr> (raw)
In-Reply-To: <4CF78B70.4060907@free.fr>
[-- Attachment #1: Type: text/plain, Size: 572 bytes --]
Hi,
Here is a second try for this patch that completes the previous one.
[PATCH] [ROSE] [AX25] finding routes simplification
With previous patch, rose_get_neigh() routine
investigates the full list of neighbor nodes
until it finds or not an already connected node whether
it is called locally or through a level 3 transit frame.
If no routes are opened through an adjacent connected node
then a classical connect request is attempted.
Then there is no more reason for an extra loop such
as the one removed by this patch.
Signed-off-by: Bernard Pidoux <f6bvp@free•fr>
[-- Attachment #2: af_rose.patch --]
[-- Type: text/x-patch, Size: 727 bytes --]
--- a/net/rose/af_rose.c 2010-12-09 23:17:27.000000000 +0100
+++ b/net/rose/af_rose.c 2010-12-19 15:06:44.399455216 +0100
@@ -803,7 +803,6 @@
rose_insert_socket(sk); /* Finish the bind */
}
-rose_try_next_neigh:
rose->dest_addr = addr->srose_addr;
rose->dest_call = addr->srose_call;
rose->rand = ((long)rose & 0xFFFF) + rose->lci;
@@ -865,12 +864,6 @@
}
if (sk->sk_state != TCP_ESTABLISHED) {
- /* Try next neighbour */
- rose->neighbour = rose_get_neigh(&addr->srose_addr, &cause, &diagnostic, 0);
- if (rose->neighbour)
- goto rose_try_next_neigh;
-
- /* No more neighbours */
sock->state = SS_UNCONNECTED;
err = sock_error(sk); /* Always set at this point */
goto out_release;
next parent reply other threads:[~2011-02-14 18:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4CF78B70.4060907@free.fr>
2011-02-14 17:52 ` Bernard Pidoux [this message]
2011-02-14 21:35 ` [PATCH] [ROSE] AX25 packet routing improvement David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D596BC9.4030509@upmc.fr \
--to=bernard.pidoux@upmc$(echo .)fr \
--cc=davem@davemloft$(echo .)net \
--cc=f6bvp@free$(echo .)fr \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ralf@linux-mips$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox