From: Larry Finger <Larry.Finger@lwfinger•net>
To: Jovi Zhang <bookjovi@gmail•com>
Cc: Ben Hutchings <bhutchings@solarflare•com>,
"John W. Linville" <linville@tuxdriver•com>,
Johannes Berg <johannes@sipsolutions•net>,
"David S. Miller" <davem@davemloft•net>,
"open list:NETWORKING [WIREL..." <linux-wireless@vger•kernel.org>,
"open list:NETWORKING [GENERAL]" <netdev@vger•kernel.org>,
open list <linux-kernel@vger•kernel.org>
Subject: Re: [PATCH] net: mac80211: fix compilation warning
Date: Sat, 05 Mar 2011 10:30:05 -0600 [thread overview]
Message-ID: <4D72650D.8070503@lwfinger.net> (raw)
In-Reply-To: <AANLkTimnSvBKSL6_d3RxufxUL_C9wCM+Fz66_B5Sc0KE@mail.gmail.com>
On 03/05/2011 07:52 AM, Jovi Zhang wrote:
> On Sat, Mar 5, 2011 at 8:31 PM, Ben Hutchings<bhutchings@solarflare•com> wrote:
>> On Wed, 2011-03-02 at 18:32 -0500, bookjovi@gmail•com wrote:
>>> From: Jovi Zhang<bookjovi@gmail•com>
>>>
>>> this commit fix compilation warning as following:
>>> net/mac80211/tx.c:1753: warning: unused variable mppath
>> [...]
>>
>> You clearly didn't try building this with CONFIG_MAC80211_MESH enabled.
>>
> Sorry, indeed, maybe should be like this:
>
> +#ifdef CONFIG_MAC80211_MESH
> struct mesh_path *mppath = NULL;
> +#endif
Linville likes "struct mesh_path *mppath __maybe_unused = NULL;" over the ifdef
form.
Larry
next prev parent reply other threads:[~2011-03-05 16:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-02 23:32 [PATCH] net: mac80211: fix compilation warning bookjovi
2011-03-05 12:31 ` Ben Hutchings
2011-03-05 13:52 ` Jovi Zhang
2011-03-05 16:30 ` Larry Finger [this message]
[not found] ` <4D72650D.8070503-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2011-03-07 4:15 ` Jovi Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D72650D.8070503@lwfinger.net \
--to=larry.finger@lwfinger$(echo .)net \
--cc=bhutchings@solarflare$(echo .)com \
--cc=bookjovi@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=johannes@sipsolutions$(echo .)net \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=linville@tuxdriver$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox