From: Dimitris Michailidis <dm@chelsio•com>
To: Ben Hutchings <bhutchings@solarflare•com>
Cc: Alexander Duyck <alexander.h.duyck@intel•com>,
Santwona Behera <santwona.behera@sun•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>
Subject: Re: [ethtool PATCH 2/2] Add RX packet classification interface
Date: Mon, 07 Mar 2011 10:22:19 -0800 [thread overview]
Message-ID: <4D75225B.3010008@chelsio.com> (raw)
In-Reply-To: <1299520664.2522.21.camel@bwh-desktop>
Ben Hutchings wrote:
> On Mon, 2011-03-07 at 09:04 -0800, Alexander Duyck wrote:
>> The only time where location really matters is if you are attempting to
>> overwrite an existing rule and I am not sure how that would be handled
>> in ntuple anyway since right now adding additional rules via ntuple for
>> ixgbe just results in duplicate rules being defined.
>
> As I understand it, the location also determines the *priority* for the
> rule.
This is true, at least for TCAMs. But it's relevant only when multiple
filters would match a packet. People often use non-overlapping filters, for
these adding the filter at any available slot is OK.
> Which is why I wrote that "@fs.@location specifies the index to
> use and must not be ignored."
>
> To support hardware where the filter table is hash-based rather than a
> TCAM, we would need some kind of flag or special value of location that
> means 'wherever'.
I'd find the 'wherever' option useful for TCAMs too. Maybe even have a few
of those, like 'first available', 'any', and 'last available'. The last one
is quite useful for catch-all rules without requiring one to know the TCAM size.
next prev parent reply other threads:[~2011-03-07 18:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-11 1:18 [ethtool PATCH 0/2] Add support for RX network flow classifier rules Alexander Duyck
2011-02-11 1:18 ` [ethtool PATCH 1/2] Add macro for displaying [value N] formatting to manpage Alexander Duyck
2011-02-21 14:45 ` Ben Hutchings
2011-02-11 1:18 ` [ethtool PATCH 2/2] Add RX packet classification interface Alexander Duyck
2011-02-21 15:40 ` Ben Hutchings
2011-02-22 20:52 ` Alexander Duyck
2011-03-01 0:35 ` Ben Hutchings
2011-03-04 19:09 ` Alexander Duyck
2011-03-07 15:57 ` Ben Hutchings
2011-03-07 17:04 ` Alexander Duyck
2011-03-07 17:57 ` Ben Hutchings
2011-03-07 18:22 ` Dimitris Michailidis [this message]
2011-03-07 18:28 ` Ben Hutchings
2011-03-07 18:43 ` Alexander Duyck
2011-03-07 18:57 ` Dimitris Michailidis
2011-03-07 19:00 ` Ben Hutchings
2011-03-07 19:11 ` Dimitris Michailidis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D75225B.3010008@chelsio.com \
--to=dm@chelsio$(echo .)com \
--cc=alexander.h.duyck@intel$(echo .)com \
--cc=bhutchings@solarflare$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=santwona.behera@sun$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox