From: Philip Prindeville <philipp_subx@redfish-solutions•com>
To: Netdev <netdev@vger•kernel.org>
Cc: "linux-atm-general@lists•sourceforge.net"
<linux-atm-general@lists•sourceforge.net>
Subject: [PATCH 1/1] solos-pci: Fix debugging to include size, vpi/vci, but omit preamble
Date: Sun, 20 Mar 2011 00:47:58 -0700 [thread overview]
Message-ID: <4D85B12E.5040005@redfish-solutions.com> (raw)
Show the buffer length, vpi, and vci as we do on receive. Use the word "port" instead of "device" consistently.
Don't display the "struct pkt_hdr" preamble on the sk_buff when doing hexdump of frame data.
Signed-off-by: Philip Prindeville <philipp@redfish-solutions•com>
---
--- a/drivers/atm/solos-pci.c.orig 2011-03-19 12:19:06.000000000 -0600
+++ b/drivers/atm/solos-pci.c 2011-03-19 12:45:18.000000000 -0600
@@ -697,7 +697,7 @@ void solos_bh(unsigned long card_arg)
size);
}
if (atmdebug) {
- dev_info(&card->dev->dev, "Received: device %d\n", port);
+ dev_info(&card->dev->dev, "Received: port %d\n", port);
dev_info(&card->dev->dev, "size: %d VPI: %d VCI: %d\n",
size, le16_to_cpu(header->vpi),
le16_to_cpu(header->vci));
@@ -1025,8 +1025,15 @@ static uint32_t fpga_tx(struct solos_car
/* Clean up and free oldskb now it's gone */
if (atmdebug) {
+ struct pkt_hdr *header = (void *)oldskb->data;
+ int size = le16_to_cpu(header->size);
+
+ skb_pull(oldskb, sizeof(*header));
dev_info(&card->dev->dev, "Transmitted: port %d\n",
port);
+ dev_info(&card->dev->dev, "size: %d VPI: %d VCI: %d\n",
+ size, le16_to_cpu(header->vpi),
+ le16_to_cpu(header->vci));
print_buffer(oldskb);
}
reply other threads:[~2011-03-20 7:48 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D85B12E.5040005@redfish-solutions.com \
--to=philipp_subx@redfish-solutions$(echo .)com \
--cc=linux-atm-general@lists$(echo .)sourceforge.net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox