From: Wei Yongjun <yjwei@cn•fujitsu.com>
To: Steffen Klassert <steffen.klassert@secunet•com>
Cc: David Miller <davem@davemloft•net>, netdev@vger•kernel.org
Subject: Re: xfrm: Fix initialize repl field of struct xfrm_state
Date: Mon, 21 Mar 2011 17:10:31 +0800 [thread overview]
Message-ID: <4D871607.6090508@cn.fujitsu.com> (raw)
In-Reply-To: <20110321082512.GB27581@secunet.com>
> On Sun, Mar 20, 2011 at 11:46:06PM -0700, David Miller wrote:
>> Ok, thanks for the explanation.
>>
>> I think there is a simple way out of this:
>>
>> 1) Rename current xfrm_init_state to __xfrm_init_state, add
>> "bool init_replay" argument. Add the xfrm_init_replay()
>> call, as in your patch, but conditionalized on this boolean.
>>
>> 2) Implement xfrm_init_state as inline, which calls
>> __xfrm_init_state(..., true)
>>
>> 3) Replace xfrm_init_state() call in xfrm_user.c with
>> __xfrm_init_state(..., false)
>>
>> This seems to avoid all the problems. We don't need to touch every
>> caller, and we avoid initializing the replay state twice in xfrm_user
>>
> Btw, looking a bit closer to this. I think it would look a bit cleaner
> if we would add the xfrm_init_replay() call to xfrm_init_state() and
> to move the xfrm_init_state() call in xfrm_state_construct() behind
> the assign of the replay settings.
The xfrm_init_replay() should be call after the call to
xfrm_update_ae_params(x, attrs);
since xfrm_update_ae_params() may update the replay_esn.
So we need move the xfrm_init_state() call just before return x.
The other issue:
static void xfrm_update_ae_params()
{
...
memcpy(x->replay_esn, replay_esn,
xfrm_replay_state_esn_len(replay_esn));
...
}
the memcpy() may cause memory overlap if we build a special
nl_data, we should free it and then do kmemdup()?
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger•kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2011-03-21 9:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-21 5:45 xfrm: Fix initialize repl field of struct xfrm_state Wei Yongjun
2011-03-21 5:48 ` [PATCH] " Wei Yongjun
2011-03-21 5:55 ` David Miller
2011-03-21 6:36 ` Wei Yongjun
2011-03-21 6:46 ` David Miller
2011-03-21 6:49 ` Wei Yongjun
2011-03-21 7:54 ` Steffen Klassert
2011-03-21 7:44 ` [PATCH v2] " Wei Yongjun
2011-03-21 8:00 ` David Miller
2011-03-21 8:01 ` David Miller
2011-03-21 8:37 ` [PATCH v3] " Wei Yongjun
2011-03-22 1:08 ` David Miller
2011-03-21 8:25 ` Steffen Klassert
2011-03-21 9:10 ` Wei Yongjun [this message]
2011-03-21 9:18 ` Wei Yongjun
2011-03-21 12:06 ` Steffen Klassert
2011-03-22 1:04 ` Wei Yongjun
2011-03-22 13:14 ` Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D871607.6090508@cn.fujitsu.com \
--to=yjwei@cn$(echo .)fujitsu.com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=steffen.klassert@secunet$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox