From: Sergei Shtylyov <sshtylyov@mvista•com>
To: Sriramakrishnan <srk@ti•com>
Cc: netdev@vger•kernel.org,
davinci-linux-open-source@linux•davincidsp.com,
davem@davemloft•net
Subject: Re: [PATCH] net: davinci_emac:Fix translation logic for buffer descriptor
Date: Tue, 22 Mar 2011 13:11:13 +0300 [thread overview]
Message-ID: <4D8875C1.9090004@mvista.com> (raw)
In-Reply-To: <1300788382-12658-1-git-send-email-srk@ti.com>
Hello.
On 22-03-2011 13:06, Sriramakrishnan wrote:
> With recent changes to the driver(switch to new cpdma layer),
> the support for buffer descriptor address translation logic
> is broken. This affects platforms where the physical address of
> the descriptors as seen by the DMA engine is different from the
> physical address.
> Original Patch adding translation logic support:
> Commit: ad021ae8862209864dc8ebd3b7d3a55ce84b9ea2
> Signed-off-by: Sriramakrishnan <srk@ti•com>
AFAIK, full name is required for signoff.
[...]
> diff --git a/drivers/net/davinci_emac.c b/drivers/net/davinci_emac.c
> index 082d6ea..df850fc 100644
> --- a/drivers/net/davinci_emac.c
> +++ b/drivers/net/davinci_emac.c
> @@ -1854,10 +1854,13 @@ static int __devinit davinci_emac_probe(struct platform_device *pdev)
> dma_params.rxcp = priv->emac_base + 0x660;
> dma_params.num_chan = EMAC_MAX_TXRX_CHANNELS;
> dma_params.min_packet_size = EMAC_DEF_MIN_ETHPKTSIZE;
> - dma_params.desc_mem_phys = hw_ram_addr;
> + dma_params.desc_hw_addr = hw_ram_addr;
> dma_params.desc_mem_size = pdata->ctrl_ram_size;
> dma_params.desc_align = 16;
>
> + dma_params.desc_mem_phys = (pdata->no_bd_ram) ? 0 :
Parens not needed here.
> + ((u32 __force)res->start + pdata->ctrl_ram_offset);
Here either not necessary.
WBR, Sergei
next prev parent reply other threads:[~2011-03-22 10:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-22 10:06 [PATCH] net: davinci_emac:Fix translation logic for buffer descriptor Sriramakrishnan
2011-03-22 10:11 ` Sergei Shtylyov [this message]
2011-03-22 10:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D8875C1.9090004@mvista.com \
--to=sshtylyov@mvista$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=davinci-linux-open-source@linux$(echo .)davincidsp.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=srk@ti$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox