From: Andrew Gallatin <gallatin@myri•com>
To: Stanislaw Gruszka <sgruszka@redhat•com>
Cc: netdev@vger•kernel.org, Brice Goglin <brice@myri•com>
Subject: Re: [RFC] myri10ge: small rx_done refactoring
Date: Wed, 23 Mar 2011 11:21:05 -0400 [thread overview]
Message-ID: <4D8A0FE1.1040500@myri.com> (raw)
In-Reply-To: <20110323124939.GA7834@redhat.com>
On 03/23/11 08:52, Stanislaw Gruszka wrote:
> on my i686 system, what should also make myri10ge_clean_rx_done()
> being faster.
I tested this on my very old, very weak dual-core athlon64 systems.
These machines can barely achieve 10Gb/s using a 1500b MTU with LRO.
Running 35 60 second netperf tests into the machines with the stock
driver, and again with this patch applied, I see a tiny bandwidth
increase (1.4Mb/s on average) which is statistically significant
( p < 0.001). There is no statistically significant CPU load
reduction.
> + if (len<= mgp->small_bytes) {
> + rx =&ss->rx_small;
> + bytes = mgp->small_bytes;
> + } else {
> + rx =&ss->rx_big,
Small nit: the "," above should be a ";"
Between the small bandwidth increase, and the code size reduction,
I'm very appreciative of this patch.
Thank you,
Drew
next prev parent reply other threads:[~2011-03-23 15:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-23 12:52 [RFC] myri10ge: small rx_done refactoring Stanislaw Gruszka
2011-03-23 15:21 ` Andrew Gallatin [this message]
2011-03-23 15:33 ` Stephen Hemminger
2011-03-24 8:16 ` Stanislaw Gruszka
2011-03-24 15:15 ` Stephen Hemminger
2011-03-24 15:59 ` Stanislaw Gruszka
2011-03-24 16:42 ` Ben Hutchings
2011-03-24 17:29 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D8A0FE1.1040500@myri.com \
--to=gallatin@myri$(echo .)com \
--cc=brice@myri$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sgruszka@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox