Subject: Re: [patch net-2.6] bonding: fix rx_handler locking

From: Nicolas de Pesloüan<[email-masked]>
Date: Wed, 23 Mar 2011 20:25:37 +0100

Le 22/03/2011 13:38, Jiri Pirko a écrit :
> This prevents possible race between bond_enslave and bond_handle_frame
> as reported by Nicolas by moving rx_handler register/unregister.
> slave->bond is added to hold pointer to master bonding sructure. That
> way dev->master is no longer used in bond_handler_frame.
> Also, this removes "BUG: scheduling while atomic" message
>
> Reported-by: Nicolas de Pesloüan<[email-masked]>
> Signed-off-by: Jiri Pirko<[email-masked]>

Thanks Jiri, it works.

Tested-by: Nicolas de Pesloüan <[email-masked]>

Regarding the code review, can you explain the reasons why you apparently duplicated the fields 
related to the slave/master relationship?

Do you plan to totally remove dev->master usage in bonding in a follow-up patch?

	Nicolas.