Subject: Re: [PATCH v2] net: cxgb4{,vf}: convert to hw_features

From: Dimitris Michailidis <[email-masked]>
Date: Sat, 16 Apr 2011 11:23:59 -0700

Michał Mirosław wrote:
> Signed-off-by: Michał Mirosław <[email-masked]>
> ---
> v2: cxgb4: remove now unneeded variable in t4_ethrx_handler()
>     cxgb4vf: fix hw/vlan_features values

Thanks for doing this.  The cxgb4 part looks good.  For cxgb4vf I have a 
comment below.

> @@ -2638,19 +2597,18 @@ static int __devinit cxgb4vf_pci_probe(struct pci_dev *pdev,
> -		netdev->features = (NETIF_F_SG | TSO_FLAGS |
> -				    NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM |
> -				    NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_RX |
> -				    NETIF_F_GRO);
> +		netdev->hw_features = NETIF_F_SG | TSO_FLAGS | NETIF_F_RXCSUM |
> +			NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM;
> +		netdev->vlan_features = NETIF_F_SG | TSO_FLAGS |
> +			NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM |
> +			NETIF_F_HW_VLAN_TX | NETIF_F_HIGHDMA;

This NETIF_F_HW_VLAN_TX looks misplaced.  Did you mean to add it to 
hw_features rather than vlan_features?