From: Michal Simek <monstr@monstr•eu>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: netdev@vger•kernel.org
Subject: Re: Add NAPI support to ll_temac driver
Date: Tue, 19 Apr 2011 14:26:56 +0200 [thread overview]
Message-ID: <4DAD7F90.5000704@monstr.eu> (raw)
In-Reply-To: <1303209787.3480.9.camel@edumazet-laptop>
Eric Dumazet wrote:
> Le mardi 19 avril 2011 à 11:35 +0200, Michal Simek a écrit :
>> Hi,
>>
>> I would like to try to add NAPI support for ll_temac and look if help us to
>> improve performance on Microblaze system. I would expect that bandwidth should
>> be increased.
>> We have the second non mainline driver which use tasklets and it provides better
>> performance than mainline driver but not so big that's why I think that NAPI
>> can increase performance.
>>
>> Can you please point me to any driver which I could use as a template?
>> Or any developer guide to do so.
>>
>> Do you know any other option how to improve driver performance on low speed cpu?
>>
>> I have found that driver spends a lot of time on skb allocation and preallocated
>> SKBs help a little bit. I have done a test where I increased number of
>> preallocated BDs(SKBs) for rx to 35000 and disable new BD(SKB) allocation in
>> rx_irq. 35000 BDs is setup because I need them to successfully finish netperf
>> test. I have got 25% bandwidth increasing.
>>
>> It will be also nice to be able to allocate several BDs(SKBs) which could be
>> faster than allocate them in sequence.
>
> Depends if your cpu has some cache. The best performance is to try to
> get high cache hit ratios.
Yes it has icache and dcache (write-back or write-through).
>
> One possible way to get better performance is to change driver to
> allocate skbs only right before calling netif_rx(), so that you dont
> have to access cold sk_buff data twice (once when allocating skb and put
> it in ring buffer, a second time when receiving frame)
ok. But I need to allocate BD for dma with pointer to skb where dma should copy
data to. I could do it in irq but I would have to wait till dma copy data from
ethernet controller to memory. I haven't measure how slow/fast is that copying.
>
> drivers/net/niu.c is a good example for this (NAPI + netdev_alloc_skb()
> just in time + pull in skbhead only first cache line of packet)
>
> drivers/net/ftmac100.c is also a recent driver (and probably a better
> start with less complex hardware than NIU) using these tricks
>
> { skb = netdev_alloc_skb_ip_align(netdev, 128);
> __pskb_pull_tail(skb, min(length, 64));
> }
I have change rx for napi but need to debug it a little bit. It works for some
packets but I am not able to run any test right now.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian
prev parent reply other threads:[~2011-04-19 12:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-19 9:35 Add NAPI support to ll_temac driver Michal Simek
2011-04-19 10:43 ` Eric Dumazet
2011-04-19 12:25 ` Ben Hutchings
2011-04-19 12:48 ` Michal Simek
2011-04-19 13:13 ` Eric Dumazet
2011-04-19 13:14 ` Ben Hutchings
2011-04-19 13:18 ` Michal Simek
2011-04-20 11:06 ` Michal Simek
2011-04-20 12:47 ` Ben Hutchings
2011-04-19 13:21 ` Eric Dumazet
2011-04-19 12:26 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DAD7F90.5000704@monstr.eu \
--to=monstr@monstr$(echo .)eu \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox