From: Shan Wei <shanwei@cn•fujitsu.com>
To: mirq-linux@rere•qmqm.pl, David Miller <davem@davemloft•net>,
netdev <netdev@vger•kernel.org>
Subject: Re: [PATCH] net: forcedeth: fix compile warning of not used nv_set_tso function
Date: Wed, 20 Apr 2011 09:42:15 +0800 [thread overview]
Message-ID: <4DAE39F7.1030504@cn.fujitsu.com> (raw)
In-Reply-To: <4DAE3768.9030807@cn.fujitsu.com>
This patch is against net-next.
Shan Wei wrote, at 04/20/2011 09:31 AM:
> Fix the below compile warning:
> drivers/net/forcedeth.c:4266: warning: ‘nv_set_tso’ defined but not used
>
> commit 569e146 converts forcedeth driver to use hw_features.
> So, implement function of .set_tso is abandoned.
>
> Signed-off-by: Shan Wei <shanwei@cn•fujitsu.com>
> ---
> drivers/net/forcedeth.c | 10 ----------
> 1 files changed, 0 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/net/forcedeth.c b/drivers/net/forcedeth.c
> index ec9a32d..0e1c76a 100644
> --- a/drivers/net/forcedeth.c
> +++ b/drivers/net/forcedeth.c
> @@ -4263,16 +4263,6 @@ static int nv_nway_reset(struct net_device *dev)
> return ret;
> }
>
> -static int nv_set_tso(struct net_device *dev, u32 value)
> -{
> - struct fe_priv *np = netdev_priv(dev);
> -
> - if ((np->driver_data & DEV_HAS_CHECKSUM))
> - return ethtool_op_set_tso(dev, value);
> - else
> - return -EOPNOTSUPP;
> -}
> -
> static void nv_get_ringparam(struct net_device *dev, struct ethtool_ringparam* ring)
> {
> struct fe_priv *np = netdev_priv(dev);
--
Best Regards
-----
Shan Wei
next prev parent reply other threads:[~2011-04-20 1:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-20 1:31 [PATCH] net: forcedeth: fix compile warning of not used nv_set_tso function Shan Wei
2011-04-20 1:42 ` Shan Wei [this message]
2011-04-20 3:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DAE39F7.1030504@cn.fujitsu.com \
--to=shanwei@cn$(echo .)fujitsu.com \
--cc=davem@davemloft$(echo .)net \
--cc=mirq-linux@rere$(echo .)qmqm.pl \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox