From: Jim Dykman <dykmanj@linux•vnet.ibm.com>
To: Ben Hutchings <bhutchings@solarflare•com>
Cc: netdev@vger•kernel.org,
Piyush Chaudhary <piyushc@linux•vnet.ibm.com>,
Fu-Chung Chang <fcchang@linux•vnet.ibm.com>,
"William S. Cadden" <wscadden@linux•vnet.ibm.com>,
"Wen C. Chen" <winstonc@linux•vnet.ibm.com>,
Scot Sakolish <sakolish@linux•vnet.ibm.com>,
Jian Xiao <jian@linux•vnet.ibm.com>,
"Carol L. Soto" <clsoto@linux•vnet.ibm.com>,
"Sarah J. Sheppard" <sjsheppa@linux•vnet.ibm.com>
Subject: Re: [PATCH v2 01/27] HFI: skeleton driver
Date: Thu, 21 Apr 2011 17:38:13 -0400 [thread overview]
Message-ID: <4DB0A3C5.3070009@linux.vnet.ibm.com> (raw)
In-Reply-To: <1303129399.5282.1033.camel@localhost>
On 4/18/2011 8:23 AM, Ben Hutchings wrote:
> On Sun, 2011-04-17 at 23:21 -0400, dykmanj@linux•vnet.ibm.com wrote:
>> From: Jim Dykman <dykmanj@linux•vnet.ibm.com>
>>
>> Device driver Makefile & Kconfig plumbing plus simple mod_init and mod_exit
> [...]
>> --- /dev/null
>> +++ b/drivers/net/hfi/core/hfidd_init.c
> [...]
>> +#include <linux/version.h>
>
> Never include <linux/version.h> in an in-tree driver.
>
Ok
> [...]
>> +static int __init hfidd_mod_init(void)
>> +{
>> + int rc = 0;
>> +
>> + rc = hfidd_create_class();
>> + if (rc < 0) {
>> + printk(KERN_ERR "%s: hfidd_mod_init: hfidd_create_class failed"
>> + " rc=%d\n", HFIDD_DEV_NAME, rc);
>> + return -1;
>
> Should be 'return rc'.
>
Ok
> [...]
>> --- /dev/null
>> +++ b/include/linux/hfi/hfidd_client.h
> [...]
>> +#ifndef _HFIDD_CLIENT_H_
>> +#define _HFIDD_CLIENT_H_
>> +
>> +#define MAX_TORRENTS 1
>> +#define MAX_HFI_PER_TORRENT 2
>> +#define MAX_HFIS (MAX_TORRENTS * MAX_HFI_PER_TORRENT)
> [...]
>
> Are you sure you want to expose these values to userland? You can never
> change them later.
>
We really don't expect them to change, so we're comfortable with defines for them.
> Ben.
>
Thanks for the reviews Ben.
Jim
next prev parent reply other threads:[~2011-04-21 23:37 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-18 3:21 [PATCH v2 00/27] HFI: minimal device driver/ip driver dykmanj
2011-04-18 3:21 ` [PATCH v2 01/27] HFI: skeleton driver dykmanj
2011-04-18 12:23 ` Ben Hutchings
2011-04-21 21:38 ` Jim Dykman [this message]
2011-04-18 3:21 ` [PATCH v2 02/27] HFI: Add HFI adapter control structure dykmanj
2011-04-18 12:19 ` Ben Hutchings
2011-04-21 21:38 ` Jim Dykman
2011-04-18 3:21 ` [PATCH v2 03/27] HFI: Add device_create/device_destroy calls for HFI devices dykmanj
2011-04-18 3:21 ` [PATCH v2 04/27] HFI: Find HFI devices in the device tree dykmanj
2011-04-18 3:21 ` [PATCH v2 05/27] HFI: The first few HFI-specific hypervisor calls dykmanj
2011-04-18 3:21 ` [PATCH v2 06/27] HFI: Add DD calls to START/STOP INTERFACE HCALLs dykmanj
2011-04-18 3:21 ` [PATCH v2 07/27] HFI: Add nMMU start/stop hypervisor calls dykmanj
2011-04-18 3:21 ` [PATCH v2 08/27] HFI: DD request framework and first HFI DD request dykmanj
2011-04-18 3:21 ` [PATCH v2 09/27] HFI: Add HFI window resource tracking dykmanj
2011-04-18 3:21 ` [PATCH v2 10/27] HFI: HFIDD_REQ_OPEN_WINDOW request dykmanj
2011-04-18 3:21 ` [PATCH v2 11/27] HFI: Check window number/assign window number dykmanj
2011-04-18 3:21 ` [PATCH v2 12/27] HFI: Sanity check send and receive fifo parameters dykmanj
2011-04-18 3:21 ` [PATCH v2 13/27] HFI: Send and receive fifo address translation dykmanj
2011-04-18 3:21 ` [PATCH v2 14/27] HFI: Add hypercalls to create/modify/free page tables in the nMMU dykmanj
2011-04-18 3:21 ` [PATCH v2 15/27] HFI: Set up nMMU page tables for the send and receive fifos dykmanj
2011-04-18 3:21 ` [PATCH v2 16/27] HFI: Add window open hypervisor call dykmanj
2011-04-18 3:21 ` [PATCH v2 17/27] HFI: Set up and call the open window hypercall dykmanj
2011-04-18 3:21 ` [PATCH v2 18/27] HFI: Map window registers into user process dykmanj
2011-04-18 3:21 ` [PATCH v2 19/27] HFI: Add window close request dykmanj
2011-04-18 3:21 ` [PATCH v2 20/27] HFI: Close window hypervisor call dykmanj
2011-04-18 3:21 ` [PATCH v2 21/27] HFI: Add send and receive interrupts dykmanj
2011-04-18 3:21 ` [PATCH v2 22/27] HFI: Add event notifications dykmanj
2011-04-18 3:21 ` [PATCH v2 23/27] HFI: Define packet header formats and window register offsets dykmanj
2011-04-18 3:21 ` [PATCH v2 24/27] HFI: hfi_ip network driver dykmanj
2011-04-18 3:21 ` [PATCH v2 25/27] HFI: hfi_ip fifo transmit paths dykmanj
2011-04-18 3:21 ` [PATCH v2 26/27] HFI: hfi_ip fifo receive path dykmanj
2011-04-18 3:21 ` [PATCH v2 27/27] HFI: hfi_ip ethtool support dykmanj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DB0A3C5.3070009@linux.vnet.ibm.com \
--to=dykmanj@linux$(echo .)vnet.ibm.com \
--cc=bhutchings@solarflare$(echo .)com \
--cc=clsoto@linux$(echo .)vnet.ibm.com \
--cc=fcchang@linux$(echo .)vnet.ibm.com \
--cc=jian@linux$(echo .)vnet.ibm.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=piyushc@linux$(echo .)vnet.ibm.com \
--cc=sakolish@linux$(echo .)vnet.ibm.com \
--cc=sjsheppa@linux$(echo .)vnet.ibm.com \
--cc=winstonc@linux$(echo .)vnet.ibm.com \
--cc=wscadden@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox