Subject: Re: [PATCH] linux/stmmac.h: include <linux/platform_device.h> to remove compilation warning.

From: Giuseppe CAVALLARO <[email-masked]>
Date: Mon, 02 May 2011 14:46:09 +0200

On 5/2/2011 8:30 AM, Viresh Kumar wrote:
> stmmac.h uses struct platform_device and doesn't include
> <linux/platform_device.h>. And so we get following compilation warning while
> using this file:
> 	warning: ‘struct platform_device’ declared inside parameter list
> 
> This patch includes <linux/platform_device.h> in stmmac.h to remove this warning

Hi Viresh

thanks for the patch that looks good for me.
We could also remove this inclusion (see commit
1f0f63885658889b3bcb8a08fbcb9532f8e536c9) from
drivers/net/stmmac/stmmac.h and keep it in linux/stmmac.h as you suggested.

What do you think?

Regards
Peppe

> Signed-off-by: Viresh Kumar <[email-masked]>
> ---
>  include/linux/stmmac.h |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/stmmac.h b/include/linux/stmmac.h
> index 73d9b4e..d7dfe7d 100644
> --- a/include/linux/stmmac.h
> +++ b/include/linux/stmmac.h
> @@ -26,6 +26,8 @@
>  #ifndef __STMMAC_PLATFORM_DATA
>  #define __STMMAC_PLATFORM_DATA
>  
> +#include <linux/platform_device.h>
> +
>  #define STMAC_TYPE_0	0
>  #define STMAC_TYPE_1	1
>  #define STMAC_TYPE_2	2