Subject: Re: [PATCH net-next 1/2 RESEND v3] net: use NETIF_F_ALL_TSO for vlan features

From: Shan Wei <[email-masked]>
Date: Thu, 12 May 2011 17:54:03 +0800

Dimitris Michailidis wrote, at 2011年05月12日 00:35:
> On 05/10/2011 11:24 PM, Shan Wei wrote:
>> As Dimitris Michailidis suggested, use NETIF_F_ALL_TSO for vlan_features,
>> which is a mask, but not hw_features.
>>
>> Signed-off-by: Shan Wei <[email-masked]>
> 
> While these changes aren't wrong I don't see a good reason to make them.  I am also curious why you're changing only these three drivers.

A personal reason to quickly know what device supports ALL TSO,
not to search one by one. :;)

TSO offloads are assigned directly in these three drivers.
Other drivers set vlan_features as hw_features, or set TSO offloads after doing some check.

-- 
Best Regards
-----
Shan Wei