Subject: Re: [PATCH v4 01/27] HFI: skeleton driver

From: Brian King <[email-masked]>
Date: Fri, 20 May 2011 13:37:50 -0500

On 04/25/2011 04:23 PM, [email-masked] wrote:
> +static int __init hfidd_mod_init(void)
> +{
> +	int			rc = 0;
> +
> +	rc = hfidd_create_class();
> +	if (rc < 0) {
> +		printk(KERN_ERR "%s: hfidd_mod_init: hfidd_create_class failed"
> +			" rc=%d\n", HFIDD_DEV_NAME, rc);
> +		return rc;
> +	}
> +
> +	printk(KERN_INFO "IBM hfi device driver loaded sucessfully\n");
> +	return 0;
> +}

This driver doesn't seem to attach to a bus like a normal driver, which breaks
things like udev being able to automatically load the driver, for example. It
also breaks tools trying to correlate between the kernel logical device and
the device in the device tree. It seems like you depend on and use a bit of
the ibmebus infrastructure. Can we have this device off that bus? 

Thanks,

Brian

-- 
Brian King
Linux on Power Virtualization
IBM Linux Technology Center