From: Ben Greear <greearb@candelatech•com>
To: netdev <netdev@vger•kernel.org>
Subject: patch for ixgbe-3.3.9 (out-of-tree) driver.
Date: Wed, 01 Jun 2011 10:50:25 -0700 [thread overview]
Message-ID: <4DE67BE1.3060704@candelatech.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 672 bytes --]
Using 'ethtool -t ethX' with 82598 chipset causes
kernel splats because spin-lock wasn't initialized properly.
This can probably cause other problems, but I'm not certain
of that.
I can't tell that anyone actually watches the sourceforge list,
so posting it here...
The reason I'm using the out-of-tree driver is that a customer
reports link bouncing when using the 82598 NIC. They are stuck
on a .34 kernel at the moment, so maybe it's fixed upstream already.
At any rate, I can't reproduce the problem locally, but the 3.3.9
driver appears to work for them.
Thanks,
Ben
--
Ben Greear <greearb@candelatech•com>
Candela Technologies Inc http://www.candelatech.com
[-- Attachment #2: ixgbe-3.3.9.patch --]
[-- Type: text/plain, Size: 948 bytes --]
--- ixgbe-3.3.9/src/ixgbe_main.c 2011-04-19 16:06:31.000000000 -0700
+++ ixgbe-3.3.9.ben/src/ixgbe_main.c 2011-06-01 10:31:23.163839562 -0700
@@ -5843,16 +5843,18 @@
adapter->flags |= IXGBE_FLAG_SRIOV_CAPABLE;
if (hw->device_id == IXGBE_DEV_ID_82599_T3_LOM)
adapter->flags2 |= IXGBE_FLAG2_TEMP_SENSOR_CAPABLE;
-#ifdef NETIF_F_NTUPLE
- /* n-tuple support exists, always init our spinlock */
- spin_lock_init(&adapter->fdir_perfect_lock);
-#endif /* NETIF_F_NTUPLE */
adapter->max_msix_q_vectors = IXGBE_MAX_MSIX_Q_VECTORS_82599;
break;
default:
break;
}
- /* Default DCB settings, if applicable */
+
+#ifdef NETIF_F_NTUPLE
+ /* n-tuple support exists, always init our spinlock */
+ spin_lock_init(&adapter->fdir_perfect_lock);
+#endif /* NETIF_F_NTUPLE */
+
+ /* Default DCB settings, if applicable */
adapter->ring_feature[RING_F_DCB].indices = 8;
if (adapter->flags & IXGBE_FLAG_DCB_CAPABLE) {
next reply other threads:[~2011-06-01 17:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-01 17:50 Ben Greear [this message]
2011-06-01 20:17 ` patch for ixgbe-3.3.9 (out-of-tree) driver Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DE67BE1.3060704@candelatech.com \
--to=greearb@candelatech$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox