From: James Chapman <jchapman@katalix•com>
To: Al Viro <viro@ZenIV•linux.org.uk>
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH] fix return values of l2tp_dfs_seq_open()
Date: Sun, 05 Jun 2011 12:05:25 +0100 [thread overview]
Message-ID: <4DEB62F5.70005@katalix.com> (raw)
In-Reply-To: <20110605105403.GC11521@ZenIV.linux.org.uk>
On 05/06/2011 11:54, Al Viro wrote:
> More fallout from struct net lifetime rules review: PTR_ERR() is *already*
> negative and failing ->open() should return negatives on failure.
>
> Signed-off-by: Al Viro <viro@zeniv•linux.org.uk>
> ---
> diff --git a/net/l2tp/l2tp_debugfs.c b/net/l2tp/l2tp_debugfs.c
> index b8dbae8..7613013 100644
> --- a/net/l2tp/l2tp_debugfs.c
> +++ b/net/l2tp/l2tp_debugfs.c
> @@ -258,7 +258,7 @@ static int l2tp_dfs_seq_open(struct inode *inode, struct file *file)
> */
> pd->net = get_net_ns_by_pid(current->pid);
> if (IS_ERR(pd->net)) {
> - rc = -PTR_ERR(pd->net);
> + rc = PTR_ERR(pd->net);
> goto err_free_pd;
> }
>
Whoops. Thanks Al.
Signed-off-by: James Chapman <jchapman@katalix•com>
--
James Chapman
Katalix Systems Ltd
http://www.katalix.com
Catalysts for your Embedded Linux software development
next prev parent reply other threads:[~2011-06-05 11:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-04 22:25 [RFC] breakage in sysfs_readdir() and s_instances abuse in sysfs Al Viro
2011-06-05 10:37 ` [PATCH] get_net_ns_by_fd() oopses if proc_ns_fget() returns an error Al Viro
2011-06-05 10:54 ` [PATCH] fix return values of l2tp_dfs_seq_open() Al Viro
2011-06-05 11:05 ` James Chapman [this message]
2011-06-05 21:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DEB62F5.70005@katalix.com \
--to=jchapman@katalix$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=viro@ZenIV$(echo .)linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox