From: Brian Haley <brian.haley@hp•com>
To: "Bjørn Mork" <bjorn@mork•no>
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH] Disable router anycast address for /127 prefixes
Date: Fri, 01 Jul 2011 15:09:57 -0400 [thread overview]
Message-ID: <4E0E1B85.1080906@hp.com> (raw)
In-Reply-To: <87y60hsvr2.fsf@nemi.mork.no>
On 07/01/2011 02:26 PM, Bjørn Mork wrote:
> Brian Haley <brian.haley@hp•com> writes:
>> On 07/01/2011 07:22 AM, Bjørn Mork wrote:
>>> RFC 6164 requires that routers MUST disable Subnet-Router anycast
>>> for the prefix when /127 prefixes are used.
>>>
>>> Signed-off-by: Bjørn Mork <bjorn@mork•no>
>>> ---
>>
>>> @@ -1479,6 +1481,8 @@ static void addrconf_join_anycast(struct inet6_ifaddr *ifp)
>>> static void addrconf_leave_anycast(struct inet6_ifaddr *ifp)
>>> {
>>> struct in6_addr addr;
>>> + if (ifp->prefix_len == 127) /* RFC 6164 */
>>> + return;
>>> ipv6_addr_prefix(&addr, &ifp->addr, ifp->prefix_len);
>>> if (ipv6_addr_any(&addr))
>>> return;
>>
>> I'm not sure you'd need this part as there shouldn't be a /127 in the list to remove.
>
> I don't understand exactly what you mean here....
If you never add an anycast address when the prefix length is 127, the address
wouldn't be there when you went to remove it. In other words, the call to
__ipv6_dev_ac_dec() would return -ENOENT, which is ignored anyways.
It's not a common codepath so the two lines of code wouldn't hurt anything
I guess...
-Brian
next prev parent reply other threads:[~2011-07-01 19:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-30 17:47 IPv6 /127 address Stephen Hemminger
2011-07-01 11:22 ` [PATCH] Disable router anycast address for /127 prefixes Bjørn Mork
2011-07-01 14:45 ` Brian Haley
2011-07-01 18:26 ` Bjørn Mork
2011-07-01 19:09 ` Brian Haley [this message]
2011-07-02 9:38 ` Bjørn Mork
2011-07-06 9:04 ` [PATCH v2] " Bjørn Mork
2011-07-07 11:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E0E1B85.1080906@hp.com \
--to=brian.haley@hp$(echo .)com \
--cc=bjorn@mork$(echo .)no \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox