From: Ang Way Chuang <wcang@sfc•wide.ad.jp>
To: Eric Dumazet <eric.dumazet@gmail•com>, netdev@vger•kernel.org
Cc: "Linus Lüssing" <linus.luessing@web•de>,
"Herbert Xu" <herbert@gondor•apana.org.au>
Subject: Re: IPv6 multicast snooping behaviour on 2.6.39-rc2 and later
Date: Tue, 23 Aug 2011 21:31:36 +0900 [thread overview]
Message-ID: <4E539DA8.1070504@sfc.wide.ad.jp> (raw)
In-Reply-To: <1314093424.2219.3.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
Sorry for the blurb. I hope I've configured thunderbird properly to send in plain text. Hope you received my reply. I tried your patch on 3.0.3 and it didn't fix the problem.
Regards,
Ang
On 23/08/11 18:57, Eric Dumazet wrote:
> Le mardi 23 août 2011 à 17:41 +0900, Ang Way Chuang a écrit :
>> Hi all,
>>
>> Sorry for cross-posting. I have a testbed setup on my VM
>> environment that needs to use MLDv2 report message. My PIM router
>> which is connected to a port on the bridge relies upon MLDv2 message
>> to work. However, the setup failed to work after 2.6.39-rc2 or later.
>> MLDv2 won't be forwarded to any slave ports bound to the bridge
>> interface. Specifically, I track the cause down to this commit id:
>>
>> ff9a57a62afbbe2d0f3a09af321f1fd7645f38a5
>>
>> However, as soon as I disable multicast snooping on sysfs, MLDv2
>> message can be forwarded again.
>>
>> I am not knowledgeable on the subject of multicast snooping, but
>> is this right behaviour for multicast snooping? IPv4 doesn't seem to
>> suffer the same fate though, IGMP can be forwarded even if
>> multicast_snooping is enabled. Thank you in advance.
>>
> Thanks very much for the report and your tracking.
>
> Added some CC
>
> I wonder if the ff9a57a62afb commit doesnt uncover a prior bug, could
> you try the following patch ?
>
> Thanks !
>
> diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
> index 2d85ca7..51e3b2d 100644
> --- a/net/bridge/br_multicast.c
> +++ b/net/bridge/br_multicast.c
> @@ -1520,6 +1520,7 @@ static int br_multicast_ipv6_rcv(struct net_bridge *br,
> err = pskb_trim_rcsum(skb2, len);
> if (err)
> goto out;
> + icmp6h = icmp6_hdr(skb2);
> }
>
> switch (skb2->ip_summed) {
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger•kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2011-08-23 12:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-23 8:41 IPv6 multicast snooping behaviour on 2.6.39-rc2 and later Ang Way Chuang
2011-08-23 9:57 ` Eric Dumazet
2011-08-23 12:31 ` Ang Way Chuang [this message]
2011-08-23 13:10 ` Eric Dumazet
2011-08-23 14:04 ` Ang Way Chuang
2011-08-23 17:24 ` Ang Way Chuang
2011-08-24 4:56 ` [PATCH] bridge: Pseudo-header required for the checksum of ICMP6 header of MLD Ang Way Chuang
2011-08-24 5:06 ` David Miller
2011-08-24 7:04 ` IPv6 multicast snooping behaviour on 2.6.39-rc2 and later Yan, Zheng
2011-08-24 7:22 ` Eric Dumazet
2011-08-24 7:38 ` Ang Way Chuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E539DA8.1070504@sfc.wide.ad.jp \
--to=wcang@sfc$(echo .)wide.ad.jp \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=linus.luessing@web$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox