Subject: Re: [PATCH 5/7] bnx2x: do not set TPA flags and features in bnx2x_init_bp

From: Michal Schmidt <[email-masked]>
Date: Tue, 30 Aug 2011 19:15:21 +0200

On 08/30/2011 06:21 PM, Vlad Zolotarov wrote:
> NACK
>
> This patch will cause the bnx2x to initialize HW with LRO disabled on the
> first ifup because our code considers the TPA_ENABLE_FLAG when desiding on
> whether LRO is enabled or not. ethtool would still report the LRO on though!

I see. I thought register_netdevice() would always call 
bnx2x_set_features(), but this is not the case.

Patch 7/7 has a similar problem with RX_VLAN_STRIP_FLAG then.

Michal