From: Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public•gmane.org>
To: Oliver Hartkopp <socketcan-fJ+pQTUTwRTk1uMJSBkQmQ@public•gmane.org>
Cc: SocketCAN Core Mailing List
<socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public•gmane.org>,
Netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
linux-g4cQ8AsIbFbL9ATBNaCtXw@public•gmane.org,
Thomas Wiedemann <Thomas.Wiedemann-8kCRUXUQ4vU@public•gmane.org>
Subject: Re: [PATCH net-next-2.6] can/sja1000: driver for PEAK PCAN PCI/PCIe cards
Date: Fri, 09 Sep 2011 17:20:18 +0200 [thread overview]
Message-ID: <4E6A2EB2.5070601@grandegger.com> (raw)
In-Reply-To: <4E6A25EE.3000501-fJ+pQTUTwRTk1uMJSBkQmQ@public.gmane.org>
Hi Oliver,
On 09/09/2011 04:42 PM, Oliver Hartkopp wrote:
> Hello Wolfgang,
>
> many thanks for providing this patch!
>
> On 09/08/11 22:07, Wolfgang Grandegger wrote:
>
>> This patch adds the "peak_pci" driver for the PCAN PCI/PCIe cards (1, 2, 3
>> or 4 channels) from PEAK Systems (http://www.peak-system.com).
>
>
> Yes - that fits, but ...
>
>
>> +#define PEAK_PCI_VENDOR_ID 0x001C /* The PCI device and vendor IDs */
>> +#define PEAK_PCI_DEVICE_ID 0x0001 /* for PCI / PCIe slot cards */
>> +#define PEAK_PCIE_DEVICE_ID 0x0002 /* for PCIExpress cards */
>> +
>> +static const u16 peak_pci_icr_masks[] = {0x02, 0x01, 0x40, 0x80};
>> +
>> +static DEFINE_PCI_DEVICE_TABLE(peak_pci_tbl) = {
>> + {PEAK_PCI_VENDOR_ID, PEAK_PCI_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID,},
>> + {PEAK_PCI_VENDOR_ID, PEAK_PCIE_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID,},
>> + {0,}
>> +};
>
>
> The problem is the support of the PCAN ExpressCard (device ID 0x0002) here.
>
> This commit
>
> https://lists.berlios.de/pipermail/socketcan-commit/2010-June/000814.html
>
> should be reverted, as you can use the PCAN-ExpressCard (IPEH-00300[12]) only
> with a hardware patch, as we need some I2C initialisations to enable the CAN
> transceiver (and the funky status LEDs). See at:
>
> http://anonscm.debian.org/gitweb/?p=collab-maint/peak-linux-driver.git;a=blob;f=driver/src/pcan_pciec.c;h=87ce0bda41aa0a6dda8284d48237b1ef7c678e11;hb=HEAD#l36
OK, I see, I will revert then. I already realized the I2C stuff for the
PCAN-ExpressCard. Obviously Thomas does not use that card but a PCIe
slot cards
> I'll also test your driver on Monday.
Thanks,
Wolfgang.
next prev parent reply other threads:[~2011-09-09 15:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-08 20:07 [PATCH net-next-2.6] can/sja1000: driver for PEAK PCAN PCI/PCIe cards Wolfgang Grandegger
[not found] ` <4E692080.9020801-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2011-09-09 14:42 ` Oliver Hartkopp
[not found] ` <4E6A25EE.3000501-fJ+pQTUTwRTk1uMJSBkQmQ@public.gmane.org>
2011-09-09 15:20 ` Wolfgang Grandegger [this message]
2011-09-12 15:49 ` Oliver Hartkopp
[not found] ` <4E6E2A21.7010701-fJ+pQTUTwRTk1uMJSBkQmQ@public.gmane.org>
2011-09-13 7:38 ` Wolfgang Grandegger
2011-09-27 14:58 ` Thomas Wiedemann
2011-09-29 9:21 ` Thomas Wiedemann
[not found] ` <OFA1D2B7AC.618D2DB3-ONC125791A.0032F517-C125791A.00335871-Npw8gZsewqCELgA04lAiVw@public.gmane.org>
2011-09-29 10:39 ` Wolfgang Grandegger
[not found] ` <4E844AFB.3020201-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2011-09-29 11:46 ` Antwort: " Thomas Wiedemann
[not found] ` <OF72B7C0BE.EE4FAB88-ONC125791A.004029CC-C125791A.004097EF-Npw8gZsewqCELgA04lAiVw@public.gmane.org>
2011-09-29 11:54 ` Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E6A2EB2.5070601@grandegger.com \
--to=wg-5yr1bzd7o62+xt7jha+gda@public$(echo .)gmane.org \
--cc=Netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=Thomas.Wiedemann-8kCRUXUQ4vU@public$(echo .)gmane.org \
--cc=linux-g4cQ8AsIbFbL9ATBNaCtXw@public$(echo .)gmane.org \
--cc=socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public$(echo .)gmane.org \
--cc=socketcan-fJ+pQTUTwRTk1uMJSBkQmQ@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox