Subject: Re: [PATCH] ipv6: Send ICMPv6 RSes only when RAs are accepted

From: Tore Anderson <[email-masked]>
Date: Fri, 16 Sep 2011 23:43:01 +0200

* David Miller

> From: Tore Anderson <[email-masked]>
> Date: Mon, 29 Aug 2011 14:08:33 +0200
> 
>> The change also makes "Hybrid Router" forwarding mode ("forwarding"
>> sysctl set to 2) redundant, as the only thing that distinguished it from
>> the standard Router mode (forwarding=1) was that RSes was being sent. It
>> has therefore been removed.
> 
> You're not removing "accept_ra==2", it's still there in the test:
> 
>> -	if ((ifp->idev->cnf.forwarding == 0 ||
>> -	     ifp->idev->cnf.forwarding == 2) &&
>> +	if (((ifp->idev->cnf.accept_ra == 1 && !ifp->idev->cnf.forwarding) ||
>> +	     ifp->idev->cnf.accept_ra == 2) &&
> 
> And it does provide it's own unique behavior compared to
> "accept_ra==1".

Hi David,

I'm not removing accept_ra==2, no, only forwarding==2. Or, more
precisely, I'm only removing the *documentation* for forwarding==2;
forwarding==2 will still work, but there's no difference from
forwarding==1 any longer.

-- 
Tore Anderson